Merged
Conversation
When a treatment-level subset lacks sufficient unique values, _fit_numerator/_fit_denominator append None to the fits list. summary() now skips None entries to avoid AttributeError.
Contributor
Author
|
As emailed - @ryan-odea - you seem to have been removed from the CausalInference org on GitHub - which means I can no longer request you as a reviewer. Honestly I think we need you re-added. Do you want to reply here if ok with this tiny change. |
Collaborator
This looks good to me! I've emailed Miguel about my access. Hopefully added back to the repos soon. |
Contributor
Author
|
Thanks Ryan. That is hopefully good news about the org and repos. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a treatment-level subset lacks sufficient unique values, _fit_numerator/_fit_denominator append None to the fits list.
summary()now skips None entries to avoid AttributeError.