Merged
Conversation
remlapmot
approved these changes
Mar 19, 2026
Contributor
remlapmot
left a comment
remlapmot
left a comment
There was a problem hiding this comment.
Superb work Ryan.
My short course practical is actually giving basically the same estimates as the R one now - will email.
I have added a small regression test.
…x_categories_for_predict Add isinstance check to silence pyright warning on CategoricalDtype
remlapmot
force-pushed
the
fix-nan-creation
branch
from
7e945b4 to
5114a23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have potentially found what was causing some Nan proliferation in your data (and any other data).
The category casting was forcing everything to be strings, which then would be coerced back to mismatched types. I've also added the fixed casting to all of the prediction tools.
I decided to change the probability warning to valueError - let me know how you feel about this. I think the strict error is maybe more useful than a probability which converges quickly at$1 - 0.5^t$