Fix bootstrapping to use paired per-iteration estimates instead and some docs amends#39
Closed
Fix bootstrapping to use paired per-iteration estimates instead and some docs amends#39
Conversation
…instead of independent delta method Centre RR CI on the point estimate rather than mean Compute RR SE CI on log scale using bootstrap mean and SE of log(RR), then back-transform
remlapmot
changed the title
ryan-odea
approved these changes
Mar 23, 2026
ryan-odea
approved these changes
Mar 23, 2026
Collaborator
ryan-odea
left a comment
ryan-odea
left a comment
There was a problem hiding this comment.
Looks good! Single comment you can take or leave
Collaborator
|
Reopening |
Collaborator
|
GHA fixed? |
Contributor
Author
|
Good decision to close. I will try to do the Release now to trigger the upload to PyPI. And just noting for the future that this PR was merged but GitHub hung on the merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This,
mirrors the fix in the R package I just sent there - in the bootstrapping use paired per-iteration estimates and monitor both risk difference and log risk ratio - there's no need for the delta-method.
Document list field defaults in SEQopts docstrings to fix
<factory>display on readthedocs site https://pyseqtarget.readthedocs.io/en/latest/sequential/seqopts.html, e.g.Fixes the incorrect display of ncores=1 on the seqopts readthedocs site
Fixes the display of summary and retrieve_data on https://pyseqtarget.readthedocs.io/en/latest/sequential/seqoutput.html
Fixes the default of
weight_preexpansionin the advanced models vignette