[ENG-10582] Add query-param to specify a tab#906
Merged
futa-ikeda merged 1 commit intoCenterForOpenScience:feature/orcid-integrationfrom Mar 13, 2026
Merged
Conversation
nsemets
requested changes
Mar 12, 2026
src/app/features/settings/profile-settings/enums/profile-settings-tab-option.enum.ts
Outdated
Show resolved
Hide resolved
src/app/features/settings/profile-settings/profile-settings.component.ts
Outdated
Show resolved
Hide resolved
src/app/features/settings/profile-settings/profile-settings.component.spec.ts
Show resolved
Hide resolved
cc010e7 to
dcbf0ed
Compare
nsemets
approved these changes
Mar 13, 2026
3e0b111
into
CenterForOpenScience:feature/orcid-integration
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Summary of Changes
tabquery-param to the settings/profile pagengOnInithook to go to correct tabScreenshot(s)
tab=3in URL barSide Effects
QA Notes