Skip to content

Optionally verify ssl#40

Merged
jacomago merged 2 commits intomasterfrom
optional_verify_ssl
Mar 20, 2026
Merged

Optionally verify ssl#40
jacomago merged 2 commits intomasterfrom
optional_verify_ssl

Conversation

@jacomago
Copy link
Contributor

No description provided.

@sonarqubecloud
Copy link

@jacomago jacomago merged commit 69115de into master Mar 20, 2026
4 of 20 checks passed
@tynanford
Copy link
Contributor

Why was this preferred over #38 ?

By setting the default value of verify_ssl to True , can the config ever override and set false? It doesn't seem so https://github.com/ChannelFinder/pyCFClient/pull/40/changes#diff-5ee044ca507b5d4fcfd727447ec2646728e825cb7aefb191c72b28f868f7de80R70

And since verify is hard-coded to False since throughout the codebase, verify_ssl = True doesn't have an effect from what I can tell

@jacomago
Copy link
Contributor Author

Why was this preferred over #38 ?

By setting the default value of verify_ssl to True , can the config ever override and set false? It doesn't seem so https://github.com/ChannelFinder/pyCFClient/pull/40/changes#diff-5ee044ca507b5d4fcfd727447ec2646728e825cb7aefb191c72b28f868f7de80R70

And since verify is hard-coded to False since throughout the codebase, verify_ssl = True doesn't have an effect from what I can tell

Because we were in a rush :/ bad form on our part. Let me create a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants