Improve the clarity of the ioc env info log#139
Merged
jacomago merged 1 commit intoChannelFinder:masterfrom Mar 20, 2026
Merged
Improve the clarity of the ioc env info log#139jacomago merged 1 commit intoChannelFinder:masterfrom
jacomago merged 1 commit intoChannelFinder:masterfrom
Conversation
jacomago
requested review from
anderslindho,
domonkos-ess,
imretoth-ess,
mdavidsaver,
ralphlange,
shroffk,
simon-ess and
tynanford
anderslindho
approved these changes
Mar 20, 2026
server/recceiver/cfstore.py
Outdated
| if iocid not in iocs: | ||
| _log.warning("IOC Env Info %s not found in ioc list: %s", ioc_info, iocs) | ||
| _log.warning( | ||
| "IOC %s did not send an initial transaction to join ioc list: %s", |
Contributor
There was a problem hiding this comment.
IOC list please - I hate reading lowercase ioc 🙃
The reason that an ioc does not appear in the ioc list is because there was not initial transaction. We have not figured out exactly what the cause of this could be, but we think the error message should be improved in this way.
jacomago
force-pushed
the
ioc-env-log-message
branch
from
628afcf to
c215fbc
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason that an ioc does not appear in the ioc list is because there was not initial transaction.
We have not figured out exactly what the cause of this could be, but we think the error message should be improved in this way.