Proxmox_ve Agent crash from possible negative age value#899
Open
Kriegsameise wants to merge 1 commit intoCheckmk:masterfrom
Open
Proxmox_ve Agent crash from possible negative age value#899Kriegsameise wants to merge 1 commit intoCheckmk:masterfrom
Kriegsameise wants to merge 1 commit intoCheckmk:masterfrom
Conversation
Possible negative value for backup age while backup is running, dont yield if it's negative
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible negative value for backup age while backup is running, dont yield if it's negative
Thank you for your interest in contributing to Checkmk!
Consider looking into Readme regarding process details.
General information
I noticed that during a running backup, the agent would crash for VMs that are configured for the piggyback data. From the crash report I went looking in the code and wrote this quick fix with which it works again, but was not able to figure out, why the value can be negative
Bug reports
CheckMK is running on a Debian 13 Host and the agent is connecting to a Proxmox Cluster of 3 Nodes. While a backup job, including a monitored VM, is running, the check crashes.
ID of submitted crash report c39eb594-1edd-11f1-9a99-92000730c8a7