191 password authentication frontend & backend; rudimentary#196
Open
saumyapalk23 wants to merge 5 commits intomainfrom
Open
191 password authentication frontend & backend; rudimentary#196saumyapalk23 wants to merge 5 commits intomainfrom
saumyapalk23 wants to merge 5 commits intomainfrom
Conversation
Vaibhav978
previously approved these changes
Apr 12, 2026
tsudhakar87
approved these changes
Apr 12, 2026
Rayna-Yu
approved these changes
Apr 12, 2026
nshoreibah-kvyo
approved these changes
Apr 16, 2026
nshoreibah-kvyo
left a comment
nshoreibah-kvyo
left a comment
There was a problem hiding this comment.
A couple questions but looks good to me!
| let body = await res.json(); | ||
| expect(body.message).toBe("Project not found for id: 1000"); | ||
| }); | ||
| test("update project test 🌞", async () => { |
There was a problem hiding this comment.
Were these tests flaking? Why'd we delete?
| testEnvironment: 'node', | ||
| testMatch: ['**/*.test.ts'], | ||
| globals: { 'ts-jest': { isolatedModules: true } }, | ||
| maxWorkers: 1, |
nourshoreibah
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #191
📝 Description
✔️ Verification
Navigate to /login — submit with empty fields, confirm validation errors appear; submit with a bad email format (e.g. saumyagmail.com), confirm email error appears
Click "Forgot password?" — confirm it navigates to /forgot-password
On /forgot-password, enter a valid email and click "Request reset link" — the API call will fail since POST /auth/forgot-password is not yet implemented on the backend, but the page correctly catches the error and the UI flow can still be verified
Click "Back to login" — confirm it navigates to /login
Navigate to /reset-password — enter mismatched or weak passwords, confirm validation errors appear; enter valid matching passwords and click "Reset Password" — the API call will fail since POST /auth/reset-password is not yet implemented
Click "Back to login" on the success screen — confirm it navigates to /login
🏕️ (Optional) Future Work / Notes