Skip to content

fix: explicitly exclude Deployment Summary from required PR checks#197

Merged
nourshoreibah merged 2 commits intomainfrom
fix/remove-deployment-summary-required-check
Apr 12, 2026
Merged

fix: explicitly exclude Deployment Summary from required PR checks#197
nourshoreibah merged 2 commits intomainfrom
fix/remove-deployment-summary-required-check

Conversation

@Vaibhav978
Copy link
Copy Markdown
Contributor

removing "Deployment Summary" from the contexts list in terraform is to make it optional.

Vaibhav978 and others added 2 commits April 12, 2026 18:27
The lambda-deploy.yml workflow has a job named "Deployment Summary" that
only runs on push to main, so it can never report status on PRs. Applying
this terraform will remove it from the live branch protection required checks.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

Terraform Plan 📖 infrastructure/github

Terraform Initialization ⚙️success

Terraform Validation 🤖success

Terraform Plan 📖success

Show Plan
data.infisical_secrets.github_folder: Reading...
data.infisical_secrets.slack_folder: Reading...
data.infisical_secrets.aws_folder: Reading...
data.infisical_secrets.cognito_folder: Reading...
data.infisical_secrets.infisical_folder: Reading...
data.infisical_secrets.slack_folder: Read complete after 1s
data.infisical_secrets.infisical_folder: Read complete after 1s
data.infisical_secrets.cognito_folder: Read complete after 1s
data.infisical_secrets.github_folder: Read complete after 1s
data.infisical_secrets.aws_folder: Read complete after 1s
github_repository.branch: Refreshing state... [id=branch]
github_actions_secret.aws_access_key_id: Refreshing state... [id=branch:AWS_ACCESS_KEY_ID]
github_branch_protection.main: Refreshing state... [id=BPR_kwDOPjZxzc4D-9hQ]
github_actions_secret.aws_secret_access_key: Refreshing state... [id=branch:AWS_SECRET_ACCESS_KEY]
github_actions_secret.cognito_client_id: Refreshing state... [id=branch:COGNITO_CLIENT_ID]
github_actions_secret.cognito_user_pool_id: Refreshing state... [id=branch:COGNITO_USER_POOL_ID]
github_branch_default.main: Refreshing state... [id=branch]
github_branch_protection.bot_state: Refreshing state... [id=BPR_kwDOPjZxzc4EU_R9]
github_actions_secret.infisical_client_secret: Refreshing state... [id=branch:INFISICAL_CLIENT_SECRET]
github_actions_secret.slack_bot_token: Refreshing state... [id=branch:SLACK_BOT_TOKEN]
github_actions_secret.gh_pat: Refreshing state... [id=branch:GH_PAT]
github_actions_secret.infisical_client_id: Refreshing state... [id=branch:INFISICAL_CLIENT_ID]
github_branch.bot_state: Refreshing state... [id=branch:bot-state]
github_repository_file.bot_state_json: Refreshing state... [id=branch:state.json:bot-state]
github_repository_file.bot_config_json: Refreshing state... [id=branch:config.json:bot-state]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # github_branch_protection.main will be updated in-place
  ~ resource "github_branch_protection" "main" {
        id                              = "BPR_kwDOPjZxzc4D-9hQ"
        # (10 unchanged attributes hidden)

      ~ required_status_checks {
          ~ contexts = [
              - "Deployment Summary",
                # (3 unchanged elements hidden)
            ]
            # (1 unchanged attribute hidden)
        }

        # (1 unchanged block hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Warning: Argument is deprecated

  with github_repository.branch,
  on main.tf line 6, in resource "github_repository" "branch":
   6:   has_downloads   = true

This attribute is no longer in use, but it hasn't been removed yet. It will
be removed in a future version. See
https://github.com/orgs/community/discussions/102145#discussioncomment-8351756

─────────────────────────────────────────────────────────────────────────────

Saved the plan to: tfplan

To perform exactly these actions, run the following command to apply:
    terraform apply "tfplan"

Pushed by: @Vaibhav978, Action: pull_request

@nourshoreibah nourshoreibah merged commit 123b9c1 into main Apr 12, 2026
13 checks passed
@nourshoreibah nourshoreibah deleted the fix/remove-deployment-summary-required-check branch April 12, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants