Open
Conversation
Juwang110
reviewed
Mar 9, 2026
Juwang110
left a comment
Juwang110
left a comment
There was a problem hiding this comment.
Overall logic looks good, just need to refactor for a non-nullable assignee
apps/backend/src/migrations/1773009000618-AddAssigneeToOrders.ts
Outdated
Show resolved
Hide resolved
| export class AddAssigneeToOrders1773009000618 implements MigrationInterface { | ||
| public async up(queryRunner: QueryRunner): Promise<void> { | ||
| await queryRunner.query(` | ||
| ALTER TABLE orders |
There was a problem hiding this comment.
Also here we can edit the dummy data to add ids for the asignee for each order
Yurika-Kan
requested changes
Mar 12, 2026
Collaborator
Yurika-Kan
left a comment
Yurika-Kan
left a comment
There was a problem hiding this comment.
would be great to implement a good structured backend as we develop our whole order matching workflow!
comments on enforcing not null & deleting stale code from old logic (pantry.volunteers)
thanks swar!
apps/backend/src/migrations/1773009000618-AddAssigneeToOrders.ts
Outdated
Show resolved
Hide resolved
Collaborator
There was a problem hiding this comment.
now unused, could you delete this here since assignee cell already uses order.assignee below
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes 135
📝 Description
✔️ Verification
UI testing