mctpd: allow bridge for assign static endpoint#148
Open
potinlai wants to merge 1 commit intoCodeConstruct:mainfrom
Open
mctpd: allow bridge for assign static endpoint#148potinlai wants to merge 1 commit intoCodeConstruct:mainfrom
potinlai wants to merge 1 commit intoCodeConstruct:mainfrom
Conversation
Allow birdge when assigning static enpoint. ``` root@bmc:~# busctl call au.com.codeconstruct.MCTP1 /au/com/codeconstruct/mctp1/interfaces/mcu1u2u1u4u1 au.com.codeconstruct.MCTP.BusOwner1 AssignEndpointStatic ayy 0 30 yisb 30 1 "/au/com/codeconstruct/mctp1/networks/1/endpoints/30" true root@bmc:~# busctl introspect au.com.codeconstruct.MCTP1 /au/com/codeconstruct/mctp1/networks/1/endpoints/30 au.com.codeconstruct.MCTP.Bridge1 NAME TYPE SIGNATURE RESULT/VALUE FLAGS .PoolEnd property y 35 const .PoolStart property y 31 const ``` Signed-off-by: Potin Lai <potin.lai@quantatw.com>
Member
|
I'm going to need more context than that commit message. What is the aim here? |
jk-ozlabs
reviewed
Mar 19, 2026
Comment on lines
+2305
to
+2309
| if (static_eid) { | ||
| new_eid = static_eid; | ||
| } else { | ||
| new_eid = alloc.start; | ||
| } |
Member
There was a problem hiding this comment.
You can't just redefine the allocated range like this, those EIDs at [static_eid, static_eid + alloc.extent] may not be available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow birdge when assigning static enpoint.
Signed-off-by: Potin Lai potin.lai@quantatw.com