Skip to content

Birmingham | 26 JAN ITP | Merve Reis | Sprint 1 | Data Groups#1021

Open
mervereis wants to merge 8 commits intoCodeYourFuture:mainfrom
mervereis:Sprint-1
Open

Birmingham | 26 JAN ITP | Merve Reis | Sprint 1 | Data Groups#1021
mervereis wants to merge 8 commits intoCodeYourFuture:mainfrom
mervereis:Sprint-1

Conversation

@mervereis
Copy link

@mervereis mervereis commented Mar 16, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Functions created as requested and test cases wroten for

@mervereis mervereis added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. labels Mar 16, 2026
@mervereis mervereis changed the title Birmingham | ITP 26 | Merve Reis | Sprint 1 | Data Groups Birmingham | 26 JAN ITP | Merve Reis | Sprint 1 | Data Groups Mar 18, 2026
cjyuan
cjyuan reviewed Mar 19, 2026
View reviewed changes
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 19, 2026
@mervereis mervereis added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 22, 2026
cjyuan
cjyuan reviewed Mar 23, 2026
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other changes look good.

Sprint-1/fix/median.js
Comment on lines +27 to +28
// Copy before sort (extra safety, though filter already creates new array)
const sorted = [...numbers].sort((a, b) => a - b);
Copy link
Contributor

@cjyuan cjyuan Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need this "extra safety" to make a copy of numbers before sorting? Safety from what?

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Module-Data-Groups The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mervereis @cjyuan