Skip to content

London | 26-ITP-Jan | Oussama Mouggal | Sprint 3 | ToDo-list#1073

Open
Oussama-Mouggal wants to merge 6 commits intoCodeYourFuture:mainfrom
Oussama-Mouggal:Sprint-3-/-ToDo-list
Open

London | 26-ITP-Jan | Oussama Mouggal | Sprint 3 | ToDo-list#1073
Oussama-Mouggal wants to merge 6 commits intoCodeYourFuture:mainfrom
Oussama-Mouggal:Sprint-3-/-ToDo-list

Conversation

@Oussama-Mouggal
Copy link

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Implemented a “Delete completed tasks” feature in the ToDo app by adding the UI button, wiring it to new logic, adding jest tests as well.

@Oussama-Mouggal Oussama-Mouggal added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 22, 2026
@Edu-Vin Edu-Vin added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 22, 2026
@Edu-Vin
Copy link

Edu-Vin commented Mar 22, 2026

Well done. The main feature of the task was implemented. Concerning the delete button on the page, it will be nice to have it styled properly for consistency. It looks off on the page

@Edu-Vin Edu-Vin added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Mar 22, 2026
@Oussama-Mouggal Oussama-Mouggal added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 22, 2026
@Oussama-Mouggal
Copy link
Author

Thanks for your feedback. I edited css styling for better consistency of the button.

@Edu-Vin
Copy link

Edu-Vin commented Mar 22, 2026

Thanks for your feedback. I edited css styling for better consistency of the button.

Well done!

@Edu-Vin Edu-Vin added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants