Skip to content

NW | 2026-MAR-SDC | Ahmad Hmedan | Sprint 1 | number-system#375

Open
AhmadHmedann wants to merge 4 commits intoCodeYourFuture:mainfrom
AhmadHmedann:number-systems
Open

NW | 2026-MAR-SDC | Ahmad Hmedan | Sprint 1 | number-system#375
AhmadHmedann wants to merge 4 commits intoCodeYourFuture:mainfrom
AhmadHmedann:number-systems

Conversation

@AhmadHmedann
Copy link

@AhmadHmedann AhmadHmedann commented Mar 14, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I have answered all the questions.

@AhmadHmedann AhmadHmedann added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 14, 2026
OracPrime
OracPrime suggested changes Mar 15, 2026
View reviewed changes
Copy link

@OracPrime OracPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of errors to correct

number-systems/README.md Outdated

What is 10101 + 01010?
Answer:
Answer: 100000
Copy link

@OracPrime OracPrime Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to check this one!

number-systems/README.md Outdated

Convert the decimal number 386 to hex.
Answer:
Answer: 11E
Copy link

@OracPrime OracPrime Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you misread the question - you've converted 286 to hex!

Copy link
Author

@AhmadHmedann AhmadHmedann Mar 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. The mistakes happened because I wasn’t focused.

@OracPrime OracPrime added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 15, 2026
@AhmadHmedann AhmadHmedann added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 22, 2026
OracPrime
OracPrime approved these changes Mar 22, 2026
View reviewed changes
Copy link

@OracPrime OracPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's better!

@OracPrime OracPrime added Reviewed Volunteer to add when completing a review with trainee action still to take. Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@OracPrime OracPrime OracPrime approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AhmadHmedann @OracPrime