fix:(lib) - support colon syntax in __index method caching#41
Open
Krenuds wants to merge 1 commit intoCommunityOx:mainfrom
Open
fix:(lib) - support colon syntax in __index method caching#41Krenuds wants to merge 1 commit intoCommunityOx:mainfrom
Krenuds wants to merge 1 commit intoCommunityOx:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
__indexmetamethod inOxVehicleandOxPlayer(server + client) caches closures that captureselffrom the enclosing scope. When methods are called with:syntax (standard Lua OOP), Lua also passesselfas the first implicit argument — causing all real arguments to shift by one position.This silently corrupts any proxied method call that takes parameters:
setStored,setProperties,setOwner,setGroup,setPlate,set, etc.Example:
vehicle:setStored("garage_name", true)arrives on the JS side assetStored(vehicleTable, "garage_name")— an object as the stored value, and the garage name string as the despawn boolean.Fix
Detect whether
:or.syntax was used by checking if the first argument isself, then handle both conventions correctly. Backward-compatible — existing.syntax callers are unaffected.Files changed
lib/server/vehicle.lualib/server/player.lualib/client/player.lua