Add letmein2/name MQTT message for getting names#66
Open
aln730 wants to merge 12 commits intoComputerScienceHouse:devfrom
Open
Add letmein2/name MQTT message for getting names#66aln730 wants to merge 12 commits intoComputerScienceHouse:devfrom
aln730 wants to merge 12 commits intoComputerScienceHouse:devfrom
Conversation
|
You should change the branch to target dev :) |
Collaborator
Author
|
@BigSpaceships oh mb, that is the best practice. the thing has been tested with dev creds so it should work. edit: i hate github for adding stuff to PR without asking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an MQTT publish so that the new LetMeIn module receives the user’s name
Why
Required to display the name on the LCD screen
Test Plan
Tested in local+dev
Env Vars
None changed
Documentation
Added a line explaining what I did.
Checklist