Skip to content

Erroneous properties#3740

Merged
georgweiss merged 3 commits intoControlSystemStudio:masterfrom
lcaouen:erroneous-properties
Mar 19, 2026
Merged

Erroneous properties#3740
georgweiss merged 3 commits intoControlSystemStudio:masterfrom
lcaouen:erroneous-properties

Conversation

@lcaouen
Copy link
Contributor

@lcaouen lcaouen commented Mar 16, 2026

The settings displayed in the dialog box were not just the ones from the settings.ini but also all the parameters saved in memory after Pheobus start.
To avoid this problem, the solution is to chech the settings at the start instead of at the help dialobox opening.
Other advantage, the property files with the "reference" settings are only loaded once whereas it was done every time the dialog box was open.

  • Testing:
    • manual test

@georgweiss
Copy link
Collaborator

Looks good.

@georgweiss
Copy link
Collaborator

@lcaouen, Sonarqube is warning about method names. Can you please update to Java coding standard, i.e. method names to start with lower case?

@sonarqubecloud
Copy link

@lcaouen
Copy link
Contributor Author

lcaouen commented Mar 17, 2026

should be better now ;-)

@georgweiss georgweiss merged commit 170abdf into ControlSystemStudio:master Mar 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants