Run tests directly on tuple input#1688
Merged
david-yz-liu merged 2 commits intoCourseography:masterfrom Mar 28, 2026
Merged
Conversation
Pull Request Test Coverage Report for Build 8eeae13e-6ee3-4874-91b4-23185a1e0064Details
💛 - Coveralls |
david-yz-liu
approved these changes
Mar 28, 2026
Contributor
david-yz-liu
left a comment
There was a problem hiding this comment.
Nice work, @Purplegaze!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Restructures test-running functions (i.e.
run<...>Test) to use direct tuple input instead of splitting the tuple into arguments. This prevents unnecessary repacking of the elements back into a tuple in the following aggregation functions (i.e.run<...>Tests)(also fixed two extremely minor camel case violations for consistency, there were two functions where one character wasn't capitalized)
This will raise a conflict with the parameter renaming in #1687 since they both change CourseControllerTests, I will have to take care of that when one gets merged.
...
Screenshots of your changes (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)