Skip to content

Run tests directly on tuple input#1688

Merged
david-yz-liu merged 2 commits intoCourseography:masterfrom
Purplegaze:tuple-tests
Mar 28, 2026
Merged

Run tests directly on tuple input#1688
david-yz-liu merged 2 commits intoCourseography:masterfrom
Purplegaze:tuple-tests

Conversation

@Purplegaze
Copy link
Copy Markdown
Contributor

@Purplegaze Purplegaze commented Mar 27, 2026

Proposed Changes

Restructures test-running functions (i.e. run<...>Test) to use direct tuple input instead of splitting the tuple into arguments. This prevents unnecessary repacking of the elements back into a tuple in the following aggregation functions (i.e. run<...>Tests)

(also fixed two extremely minor camel case violations for consistency, there were two functions where one character wasn't capitalized)

This will raise a conflict with the parameter renaming in #1687 since they both change CourseControllerTests, I will have to take care of that when one gets merged.

...

Screenshots of your changes (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests) X
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.
  • I have updated the project Changelog (this is required for all changes).

After opening your pull request:

  • I have verified that the CircleCI checks have passed.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 8eeae13e-6ee3-4874-91b4-23185a1e0064

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 51 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.02%) to 57.408%

Files with Coverage Reduction New Missed Lines %
app/Controllers/Graph.hs 4 47.06%
app/Export/GetImages.hs 12 0.0%
app/Export/TimetableImageCreator.hs 35 0.0%
Totals Coverage Status
Change from base Build 30c79c7c-626a-4456-b687-c5ece563d690: 0.02%
Covered Lines: 2316
Relevant Lines: 3943

💛 - Coveralls

@Purplegaze Purplegaze requested a review from david-yz-liu March 27, 2026 17:38
Copy link
Copy Markdown
Contributor

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @Purplegaze!

@david-yz-liu david-yz-liu merged commit 3b85dea into Courseography:master Mar 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants