Skip to content

Fix memory leak in cJSON_AddItemReferenceToObject on string alloc failure #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
icsfy wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −1
Open

Fix memory leak in cJSON_AddItemReferenceToObject on string alloc failure #1008

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion cJSON.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2139,12 +2139,26 @@ CJSON_PUBLIC(cJSON_bool) cJSON_AddItemReferenceToArray(cJSON *array, cJSON *item

CJSON_PUBLIC(cJSON_bool) cJSON_AddItemReferenceToObject(cJSON *object, const char *string, cJSON *item)
{
cJSON *reference = NULL;

if ((object == NULL) || (string == NULL))
{
return false;
}

return add_item_to_object(object, string, create_reference(item, &global_hooks), &global_hooks, false);
reference = create_reference(item, &global_hooks);
if (reference == NULL)
{
return false;
}

if (!add_item_to_object(object, string, reference, &global_hooks, false))
{
cJSON_Delete(reference);
return false;
}

return true;
}

CJSON_PUBLIC(cJSON*) cJSON_AddNullToObject(cJSON * const object, const char * const name)
Expand Down