Conversation
epsig
left a comment
epsig
left a comment
There was a problem hiding this comment.
at lot of new code, interesting for the connection to Stability.
I also have some general remarks, see the issue.
|
|
||
| for (size_t i = 0; i < xSample->Values.size(); i++) | ||
| /** | ||
| * \brief Sets a callback which calculates the beat in a certain direction |
There was a problem hiding this comment.
| * \brief Sets a callback which calculates the beat in a certain direction | |
| * \brief Sets a callback which calculates the beta in a certain direction |
| #include <format> | ||
|
|
||
| namespace Deltares::Models | ||
| namespace Deltares |
There was a problem hiding this comment.
this looks like a merge error; the namespaces were on one line
| @@ -0,0 +1,69 @@ | |||
| // Copyright (C) Stichting Deltares. All rights reserved. | |||
| // | |||
There was a problem hiding this comment.
I did not expect any new or changed code in the Deltares.Probabilistic.Net folder for this issue.
There was a problem hiding this comment.
Can you point out which code you mean?
| // Stichting Deltares and remain full property of Stichting Deltares at all times. | ||
| // All rights reserved. | ||
| // | ||
| using System; |
There was a problem hiding this comment.
usused using (happens in more files)
There was a problem hiding this comment.
removed unused using
| using Deltares.Probabilistic.Model; | ||
| using Deltares.Probabilistic.Utils; | ||
|
|
||
| namespace Deltares.Probabilistic.Logging |
There was a problem hiding this comment.
namespace differs from folder
There was a problem hiding this comment.
I think Net or NetCS should not be part of the namespace, because in .Net you should not state that it is .net code. Also I think the project should be renamed to Net instead of NetCS when the C++/CLI code is not needed any more and removed
|
|
||
| public double GetXFromP(double p) | ||
| { | ||
| double u = StandardNormal.GetUFromP(p); |
There was a problem hiding this comment.
this is more than interface code ; should that not be part of the c-code ?
There was a problem hiding this comment.
yes, added it to c-code
| * \brief Sets a callback which calculates the beat in a certain direction | ||
| * \param zBetaLambda Callback | ||
| */ | ||
| void ModelRunner::setDirectionModel(ZBetaLambda zBetaLambda) const |
There was a problem hiding this comment.
zBetaLambda can be a const reference
| * \param sample Sample indicating the direction | ||
| * \return Beta | ||
| */ | ||
| double ModelRunner::getBeta(std::shared_ptr<Sample> sample) |
There was a problem hiding this comment.
sample can be const reference
may be old code but it looks new here
2 participants
No description provided.