Conversation
JoerivanEngelen
requested review from
Manangka and
verkaik
and removed request for
Manangka
docs/api/changelog.rst
Outdated
| - Fixed edge case where allocation of :class:`imod.mf6.River` package with the | ||
| ``stage_to_riv_bot`` or ``stage_to_riv_bot_drn_above`` option of | ||
| :func:`imod.prepare.ALLOCATION_OPTION` would assign river cells to the wrong | ||
| layer when was exactly equal to a bottom of a layer in the model |
There was a problem hiding this comment.
Could you fix this sentence
There was a problem hiding this comment.
Good catch! Done
| option, active, top, bottom, stage, stage | ||
| ) | ||
|
|
||
| # Override expected values |
There was a problem hiding this comment.
Why do you need to override the values here? Can't you set the expected values where you specify the cases?
There was a problem hiding this comment.
I looked into this as I was questioning the same thing; unfortunately this is not a trivial tasks. The defined expected values in the allocation option cases hold for the "normal" cases. This test tests an edge case where behavior is expected to be different for some specific combination of allocation methods and model parameters. Splitting this further into separate cases would entail quite a refactor at minimum, but I'm not even sure if its possible, and whether it would lead to a more understandable test suite.
|
2 participants
Probably Fixes #1766
Description
This fixes an edge case in the allocation of river cells when river stage == river bottom_elevation == model bottom.
Not entirely certain whether it fixes all problems @CasvHWSBrabantseDelta ran into, but it is something.
Checklist
Issue #nr, e.g.Issue #737pixi run generate-sbomand committed changes