Skip to content

Configure the config server via an environment variable#2008

Open
rtuck99 wants to merge 1 commit intomainfrom
fix_config_server_system_test_breakage
Open

Configure the config server via an environment variable#2008
rtuck99 wants to merge 1 commit intomainfrom
fix_config_server_system_test_breakage

Conversation

@rtuck99
Copy link
Copy Markdown
Contributor

@rtuck99 rtuck99 commented Apr 15, 2026

Required in order to fix the mx-bluesky system tests, since the config server needs to be configurable in order to point against the system test daq-config-server.

See also mx-bluesky PR

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.08%. Comparing base (8cf8dfb) to head (24812af).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2008   +/-   ##
=======================================
  Coverage   99.08%   99.08%           
=======================================
  Files         319      319           
  Lines       12412    12414    +2     
=======================================
+ Hits        12299    12301    +2     
  Misses        113      113           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rtuck99 rtuck99 force-pushed the improve_config_client_in_oav_params branch from 8d903da to 81e0fd4 Compare April 15, 2026 16:36
Base automatically changed from improve_config_client_in_oav_params to main April 16, 2026 09:19
@rtuck99 rtuck99 force-pushed the fix_config_server_system_test_breakage branch from 1f290fb to 24812af Compare April 16, 2026 09:27
@rtuck99 rtuck99 marked this pull request as ready for review April 16, 2026 09:31
@rtuck99 rtuck99 requested a review from a team as a code owner April 16, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant