Skip to content

Instantiate serial stages on i19-2#2012

Merged
noemifrisina merged 2 commits intomainfrom
2010-serial-stages-eh2
Apr 17, 2026
Merged

Instantiate serial stages on i19-2#2012
noemifrisina merged 2 commits intomainfrom
2010-serial-stages-eh2

Conversation

@noemifrisina
Copy link
Copy Markdown
Collaborator

Fixes #2010

Instructions to reviewer on how to test:

  1. Run dodal connect i19-2
  2. Run tests

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@noemifrisina noemifrisina requested a review from a team as a code owner April 17, 2026 13:46
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.09%. Comparing base (b73b770) to head (318c742).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2012   +/-   ##
=======================================
  Coverage   99.08%   99.09%           
=======================================
  Files         319      319           
  Lines       12416    12426   +10     
=======================================
+ Hits        12303    12313   +10     
  Misses        113      113           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@jacob720 jacob720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, dodal connect work for serial_stages and tests pass

@noemifrisina noemifrisina merged commit af2ac28 into main Apr 17, 2026
17 of 18 checks passed
@noemifrisina noemifrisina deleted the 2010-serial-stages-eh2 branch April 17, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

I19-2: new serial stages

2 participants