New signatures fixes (for review only)#30
Open
koirikivi wants to merge 67 commits intosignatures_without_new_fixesfrom
Open
New signatures fixes (for review only)#30koirikivi wants to merge 67 commits intosignatures_without_new_fixesfrom
koirikivi wants to merge 67 commits intosignatures_without_new_fixesfrom
Conversation
wss://testnet.sovryn.app/ws -> wss://testnet.sovryn.app/websocket
Passing filter: { id: } to getPastEvent doesn't work -- need to filter
in nodejs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the new fixes added by me to the signatures branch:
_requestSignaturesFromFederatorsit.onlyorjest -tand was generally ugly. Tests should always work in isolation)