Replace std::vector with uint64_t bitset in WebRequestMethodComposite#410
Closed
Replace std::vector with uint64_t bitset in WebRequestMethodComposite#410
std::vector with uint64_t bitset in WebRequestMethodComposite#410Conversation
…nd list-based composite
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: mathieucarbou <61346+mathieucarbou@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on HTTP method enum limitation
Replace Mar 14, 2026
std::vector with uint64_t bitset in WebRequestMethodComposite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebRequestMethodCompositeusedstd::vector<WebRequestMethod>internally, causing heap allocations and fragmentation on embedded targets. The question was raised whether auint64_tbitset would limit the method set to only 8 values.Changes
std::vector<WebRequestMethod>withuint64_t _bits(one bit perhttp_methodindex) +bool _anyfor the HTTP_ANY (= 255) sentinel. The entire object is now 9 bytes with no heap involvement.http_methodenum currently defines 34 values (0–33), so all methods fit with room to spare — not 8.bool _any;allows(HTTP_ANY)explicitly returnsfalse(it is not a real request method, only a match-all sentinel).All public semantics (
allows,operator==,operator|,operator&,empty,toString) are preserved.💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.