Skip to content

use analysis array fix#613

Merged
TheJeran merged 1 commit intomainfrom
jp/analysis-arr
Mar 31, 2026
Merged

use analysis array fix#613
TheJeran merged 1 commit intomainfrom
jp/analysis-arr

Conversation

@TheJeran
Copy link
Copy Markdown
Collaborator

I removed this because I thought GetCurrentArray handled this. But it doesn't. My bad

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the GPU computation logic in AnalysisWG.tsx to support chaining analysis operations by using analysisArray when analysisMode is enabled. However, the review identifies critical risks regarding dimensionality mismatches, where reduced data might not align with original shape metadata, potentially causing incorrect indexing or memory errors. Additionally, there are concerns about stale state management when the underlying dataset changes and a minor syntax inconsistency involving a missing semicolon.

@TheJeran TheJeran merged commit 30cce70 into main Mar 31, 2026
6 checks passed
@TheJeran TheJeran deleted the jp/analysis-arr branch March 31, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant