Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces several enhancements to the visualization tool, including a new 'Value Cropping' feature implemented via shader thresholds, a 'Disable Scaling' option for point clouds, and a global visualization reset function. UI improvements include reorganizing settings for better accessibility, adding close buttons to panels, and updating the navbar and transect selection logic for flat mode. Feedback focuses on ensuring state consistency by adding missing setters for new variables, handling potential 'undefined' values when passing uniforms to shaders, and correcting CSS positioning for the new reset icon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quality of life update to address some of the ideas in #593
I will let Gemini summarize as there are a lot of minor changes