Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Description
Asana task
Remove contacts modal on first receive. The contacts permission prompt no longer appears from passive thumbnail lookup when a user receives funds. It now appears only when the user opens a transaction list with named transactions or explicitly edits the payee field from transaction details.
Note
Low Risk
Low risk: changes are isolated to UI permission-prompt timing and removes a side-effect from a thumbnail hook, with no sensitive data handling beyond existing permission requests.
Overview
Adjusts when the contacts permission modal is shown so it no longer triggers during passive contact thumbnail lookup (e.g. first receive).
Centralizes the “show modal + request OS permission” behavior into a new
promptForContactsPermissionthunk, calls it fromContactListModal, and adds a guard inTransactionListSceneto only prompt when there are named transactions.Simplifies
useContactThumbnailto be a pure lookup over existing contacts state (no permission checks/modals), and updates the changelog entry to reflect the new prompt timing.Written by Cursor Bugbot for commit 43bea65. This will update automatically on new commits. Configure here.