Skip to content

Fix contacts permission prompt timing#5979

Merged
j0ntz merged 2 commits intodevelopfrom
jon/fix/remove-contacts-modal-first-receive
Mar 20, 2026
Merged

Fix contacts permission prompt timing#5979
j0ntz merged 2 commits intodevelopfrom
jon/fix/remove-contacts-modal-first-receive

Conversation

@j0ntz
Copy link
Contributor

@j0ntz j0ntz commented Mar 13, 2026

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Description

Asana task

Remove contacts modal on first receive. The contacts permission prompt no longer appears from passive thumbnail lookup when a user receives funds. It now appears only when the user opens a transaction list with named transactions or explicitly edits the payee field from transaction details.


Note

Low Risk
Low risk: changes are isolated to UI permission-prompt timing and removes a side-effect from a thumbnail hook, with no sensitive data handling beyond existing permission requests.

Overview
Adjusts when the contacts permission modal is shown so it no longer triggers during passive contact thumbnail lookup (e.g. first receive).

Centralizes the “show modal + request OS permission” behavior into a new promptForContactsPermission thunk, calls it from ContactListModal, and adds a guard in TransactionListScene to only prompt when there are named transactions.

Simplifies useContactThumbnail to be a pure lookup over existing contacts state (no permission checks/modals), and updates the changelog entry to reflect the new prompt timing.

Written by Cursor Bugbot for commit 43bea65. This will update automatically on new commits. Configure here.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants