feat(tab): add persistentTabBar option for keep the tab pinned#2186
Open
feat(tab): add persistentTabBar option for keep the tab pinned#2186
Conversation
| tabContent | ||
|
|
||
| widget._controller.persistentTabBar | ||
| ? Expanded( |
Member
There was a problem hiding this comment.
We are wrapping it with Expanded widget based on persistentTabBar, and also wrapping it with Expanded when isExpanded is also true, so if we set both properties, it gets wrapped twice in Expanded widget. Can you check if using both properties breaks it or works fine?
Verify with some edge cases:
- persistentTabBar: true + content has ListView
- persistentTabBar: true + content has Expanded child
- Tab content shorter than the screen, verify that it takes space as widget space or it takes extra space.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
persistentTabBarsupport so the tab bar stays pinned while only the tab content scrolls.Key Changes
TabBar Behavior
persistentTabBarparameter toTabBar.Usage