feat: Quantization support for elastic search#355
Open
vanitabhagwat wants to merge 6 commits intofeature/vector-storefrom
Open
feat: Quantization support for elastic search#355vanitabhagwat wants to merge 6 commits intofeature/vector-storefrom
vanitabhagwat wants to merge 6 commits intofeature/vector-storefrom
Conversation
- Add config fields: vector_index_type, hnsw_m, hnsw_ef_construction, rescore_oversample - Add use_native_knn toggle (default: false for backward compatibility) - Add knn_num_candidates_multiplier for query tuning - Comprehensive Pydantic validation for all config constraints - Support for int8, int4, bbq quantization with HNSW and flat indices - Dimension validation (int4 requires even dims, bbq requires >=64) - Dual query path: script_score (exact) vs native knn (approximate) - 17 unit tests covering config validation and index creation Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
b91534a to
d1ebd93
Compare
added 5 commits
April 8, 2026 18:22
- Fix mypy error: Argument 1 to b64decode has incompatible type - Add None check before decoding feature_value - Ensures type safety without changing behavior
- Remove unused patch import - Fix import ordering in test methods - No functional changes, all tests passing
- Auto-format with ruff for consistent code style - No functional changes, all tests passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Misc