fix(a11y): update picker-select fork, remove Android TalkBack workaround, keep iOS Done button role by TaduJR · Pull Request #85244 · Expensify/App

TaduJR · 2026-03-13T16:08:22Z

Explanation of Change

Updates the react-native-picker-select fork to acf8e54, which includes:

Upstream merge (PR #21): Merges latest upstream lawnstarter/react-native-picker-select into the Expensify fork
Android TalkBack fix (PR #19): Adds proper accessibility to the Android headless picker at the library level accessibilityRole="combobox", accessibilityLabel, accessibilityState, onAccessibilityAction handler, and importantForAccessibility="no-hide-descendants" on the inner container

Since the fork now handles Android TalkBack accessibility internally, this PR removes the consumer-level workaround added in #81013:

Removes importantForAccessibility: 'no-hide-descendants' from textInputProps
Removes touchableWrapperProps (accessible, combobox role, label, state)

The iOS touchableDoneProps (accessibilityRole: 'button') is kept because the fork does not add a built-in accessibility role to the iOS Done button it relies on the consumer to provide it via touchableDoneProps.

Fixed Issues

$ #77542
PROPOSAL: #77542 (comment)

Tests

Here are the test steps based on the issue:

Tests

Precondition: You must be logged out.

Test 1: Android TalkBack & iOS VoiceOver - Language picker announcement and activation

Using Android TalkBack, open the Expensify app
Swipe right to focus the 'Language' picker at the bottom of the page
Verify TalkBack announces Collapsed, Language, combobox (not "button disabled")
Double-tap to activate
Verify the language picker opens and a language can be selected

Test 2: iOS VoiceOver - Done button role

Using iOS VoiceOver, open the Expensify app
Swipe to the 'Language' dropdown button and double-tap to activate
Swipe to the 'Done' button in the picker view
Verify that the Done button is announced with a button role

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen_Recording_20260122_065943_New.Expensify.Dev.mp4

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…und, keep iOS Done button role

melvin-bot · 2026-03-13T16:08:30Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2026-03-13T16:08:31Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-03-13T16:08:32Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 587a08e214

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

package-lock.json

…Reader-Many-Pages-The-embedded-links-cannot-be-focused-and-activated

joekaufmanexpensify · 2026-03-13T20:47:23Z

No product review needed

package.json

…Reader-Many-Pages-The-embedded-links-cannot-be-focused-and-activated

eVoloshchak · 2026-03-17T15:52:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

eVoloshchak · 2026-03-17T18:18:48Z

Can confirm this is working as expected on Android.

TalkBack also doesn't announce the picker on mWeb Android

But on iOS the picker doesn't work at all (and not announced too)

Screen.Recording.2026-03-17.at.18.54.21.mov

Please always include all of the recordings for all of the platforms, even if the original bug and the changes are platform-specific, this is a way to catch this type of issue.

…Reader-Many-Pages-The-embedded-links-cannot-be-focused-and-activated

TaduJR · 2026-03-18T18:29:59Z

@eVoloshchak

Can confirm this is working as expected on Android.

Just tried it again, its working.

TalkBack also doesn't announce the picker on mWeb Android

Also this one works. Could you double check this one?

But on iOS the picker doesn't work at all (and not announced too)

Interesting. I thought it was working fine since the OP was reported only for Android. Raised upstream PR Expensify/react-native-picker-select#22

…Reader-Many-Pages-The-embedded-links-cannot-be-focused-and-activated # Conflicts: # src/components/Picker/BasePicker.tsx

eVoloshchak · 2026-03-24T17:45:11Z

I thought it was working fine since the OP was reported only for Android.

@TaduJR, please always test all of the test scenarios on all of the platforms in the PR checklist. Even if the bug is reported on a single platform and we fix it for a single platform, this is a good way to verify that nothing has been broken. Both PR author and C+ always go through all of the platforms when testing a PR, both for App and for forks (in this case, https://github.com/Expensify/react-native-picker-select, please check Expensify/react-native-picker-select#22 on all of the platforms)
And after Expensify/react-native-picker-select#22 is merged, please test this PR and update the Screenshots/Videos section

TaduJR · 2026-03-24T17:53:20Z

@TaduJR, please always test all of the test scenarios on all of the platforms in the PR checklist. Even if the bug is reported on a single platform and we fix it for a single platform, this is a good way to verify that nothing has been broken.

Ohh I see.

I focused on Android since the first step from the OP was

Using Android TalkBack, open the Expensify app

Thanks so much for the clarification @eVoloshchak

Really appreciate your work, and support since the issue milestone began.

Both PR author and C+ always go through all of the platforms when testing a PR, both for App and for forks (in this case, https://github.com/Expensify/react-native-picker-select, please check Expensify/react-native-picker-select#22 on all of the platforms)
And after Expensify/react-native-picker-select#22 is merged, please test this PR and update the Screenshots/Videos section

You got it 👍.

fix(a11y): update picker-select fork, remove Android TalkBack workaro…

587a08e

…und, keep iOS Done button role

TaduJR requested review from a team as code owners March 13, 2026 16:08

melvin-bot bot assigned TaduJR Mar 13, 2026

melvin-bot bot requested a review from eVoloshchak March 13, 2026 16:08

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team March 13, 2026 16:08

melvin-bot bot removed the request for review from a team March 13, 2026 16:08

chatgpt-codex-connector bot reviewed Mar 13, 2026

View reviewed changes

package-lock.json Outdated Show resolved Hide resolved

TaduJR added 2 commits March 13, 2026 20:48

fix: regenerate lockfile to resolve picker-select fork to acf8e54

2dbade7

Merge branch 'main' of https://github.com/TaduJR/App into fix-Screen-…

247a56b

…Reader-Many-Pages-The-embedded-links-cannot-be-focused-and-activated

joekaufmanexpensify removed their request for review March 13, 2026 20:47

eVoloshchak reviewed Mar 16, 2026

View reviewed changes

package.json Show resolved Hide resolved

Merge branch 'main' of https://github.com/TaduJR/App into fix-Screen-…

90fbbea

…Reader-Many-Pages-The-embedded-links-cannot-be-focused-and-activated

Merge branch 'main' of https://github.com/TaduJR/App into fix-Screen-…

3716dc6

…Reader-Many-Pages-The-embedded-links-cannot-be-focused-and-activated

TaduJR added 3 commits March 18, 2026 21:34

refactor: remove redundant picker a11y props handled by fork

a2dd375

Merge branch 'main' of https://github.com/TaduJR/App into fix-Screen-…

22b9262

…Reader-Many-Pages-The-embedded-links-cannot-be-focused-and-activated # Conflicts: # src/components/Picker/BasePicker.tsx

fix(a11y): pass localized doneText to picker for VoiceOver

ab390d1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(a11y): update picker-select fork, remove Android TalkBack workaround, keep iOS Done button role#85244

fix(a11y): update picker-select fork, remove Android TalkBack workaround, keep iOS Done button role#85244
TaduJR wants to merge 8 commits intoExpensify:mainfrom
TaduJR:fix-Screen-Reader-Many-Pages-The-embedded-links-cannot-be-focused-and-activated

TaduJR commented Mar 13, 2026

Uh oh!

melvin-bot bot commented Mar 13, 2026

Uh oh!

melvin-bot bot commented Mar 13, 2026

Uh oh!

github-actions bot commented Mar 13, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

joekaufmanexpensify commented Mar 13, 2026

Uh oh!

Uh oh!

eVoloshchak commented Mar 17, 2026 •

edited

Loading

Uh oh!

eVoloshchak commented Mar 17, 2026 •

edited

Loading

Uh oh!

TaduJR commented Mar 18, 2026

Uh oh!

eVoloshchak commented Mar 24, 2026 •

edited

Loading

Uh oh!

TaduJR commented Mar 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

TaduJR commented Mar 13, 2026

Explanation of Change

Fixed Issues

Tests

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 13, 2026

Uh oh!

melvin-bot bot commented Mar 13, 2026

Uh oh!

github-actions bot commented Mar 13, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

joekaufmanexpensify commented Mar 13, 2026

Uh oh!

Uh oh!

eVoloshchak commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eVoloshchak commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TaduJR commented Mar 18, 2026

Uh oh!

eVoloshchak commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TaduJR commented Mar 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

eVoloshchak commented Mar 17, 2026 •

edited

Loading

eVoloshchak commented Mar 17, 2026 •

edited

Loading

eVoloshchak commented Mar 24, 2026 •

edited

Loading