Skip to content

Replace FullscreenLoadingIndicator with ActivityIndicator in AttachmentCarousel#86265

Draft
MelvinBot wants to merge 2 commits intomainfrom
claude-attachmentCarouselLoadingIndicator
Draft

Replace FullscreenLoadingIndicator with ActivityIndicator in AttachmentCarousel#86265
MelvinBot wants to merge 2 commits intomainfrom
claude-attachmentCarouselLoadingIndicator

Conversation

@MelvinBot
Copy link
Contributor

@MelvinBot MelvinBot commented Mar 24, 2026

Explanation of Change

AttachmentCarousel uses FullscreenLoadingIndicator while its parent AttachmentModalBaseContent already renders a HeaderWithBackButton. Once shouldUseGoBackButton is enabled by default in FullscreenLoadingIndicator, users would see two back controls during loading.

This replaces FullscreenLoadingIndicator with an ActivityIndicator wrapped in a View that reproduces the same layout and background styling (StyleSheet.absoluteFillObject, styles.fullScreenLoading, styles.w100), making the loading state pixel-perfect identical without the Go Back button functionality.

Fixed Issues

$ #85371
PROPOSAL: #85371 (comment)

Tests

  1. Open any chat with attachments
  2. Click on an attachment to open the attachment modal
  3. Observe the loading spinner appears centered with the correct background while attachments are being loaded
  4. Verify only the header back button is visible (no duplicate Go Back button from the loader)
  5. Verify that no errors appear in the JS console
  • Verify that no errors appear in the JS console

Offline tests

  1. Turn off network connection
  2. Open a chat with previously cached attachments
  3. Click on an attachment to open the modal
  4. Verify the loading indicator displays correctly while offline

QA Steps

  1. Open any chat that has image/file attachments
  2. Tap on an attachment to open it in the attachment carousel modal
  3. Verify the loading spinner appears centered with the correct background color
  4. Verify there is no duplicate "Go Back" button — only the header back button should be visible
  5. Verify the attachment loads correctly after the spinner
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A - No visual change; the loading indicator remains pixel-perfect identical.

Android: mWeb Chrome

N/A - No visual change.

iOS: Native

N/A - No visual change.

iOS: mWeb Safari

N/A - No visual change.

MacOS: Chrome / Safari

N/A - No visual change.

@MelvinBot @situchan
Replace FullscreenLoadingIndicator with ActivityIndicator in Attachme…
836853f 
…ntCarousel

AttachmentCarousel is used inside AttachmentModalBaseContent which already
renders a HeaderWithBackButton. Replace FullscreenLoadingIndicator with
an ActivityIndicator wrapped in a View that reproduces the same layout
and background styling to avoid showing two back controls when
shouldUseGoBackButton is enabled by default.

Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
@MelvinBot MelvinBot requested a review from a team March 24, 2026 18:47
@MelvinBot MelvinBot mentioned this pull request Mar 24, 2026
Open
@MelvinBot @situchan
Fix: use StyleSheet.absoluteFill instead of deprecated absoluteFillOb…
a83c128 
…ject

Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
@MelvinBot
Copy link
Contributor Author

MelvinBot commented Mar 24, 2026

Fixed the failing ESLint check: replaced deprecated StyleSheet.absoluteFillObject with StyleSheet.absoluteFill on line 105 of AttachmentCarousel/index.tsx.

Note: The warning about setPage(-1) on line 66 is a pre-existing issue (not introduced by this PR).

@codecov
Copy link

codecov bot commented Mar 24, 2026 •
edited by github-actions bot
Loading

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...omponents/Attachments/AttachmentCarousel/index.tsx 89.65% <100.00%> (+0.36%) ⬆️
... and 26 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@situchan situchan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MelvinBot @situchan