Skip to content

Add compact UI styles for search reports and expenses tables #86283

Draft
Krishna2323 wants to merge 6 commits intoExpensify:mainfrom
Krishna2323:krishna/86202-compact-table-styles
Draft

Add compact UI styles for search reports and expenses tables #86283
Krishna2323 wants to merge 6 commits intoExpensify:mainfrom
Krishna2323:krishna/86202-compact-table-styles

Conversation

@Krishna2323
Copy link
Contributor

Explanation of Change

Fixed Issues

$ #86202
PROPOSAL:

Tests

Prerequisites: All tests are desktop/web only (wide browser window >1024px). Changes should not affect mobile layout.

Expenses Tab (TransactionListItem)

  1. Navigate to Search > Expenses (ungrouped)
  2. Verify each row has min-height 52px
  3. Verify rows have 1px bottom borders with theme.border color
  4. Verify the last row has no bottom border (borderBottomWidth: 0)
  5. Verify the last row has 8px bottom-left and bottom-right border radius
  6. Verify all non-last rows have 0px border radius
  7. Select a row — verify border color changes to theme.buttonHoveredBG
  8. Select the last row — verify it still has 8px bottom radius and no bottom border

Reports Tab (ExpenseReportListItem)

  1. Navigate to Search > Reports
  2. Verify report rows have min-height 52px, paddingVertical 8px
  3. Verify 1px bottom borders between rows
  4. Verify the last report row has no bottom border and 8px bottom border radius

Tasks (TaskListItem)

  1. Search for tasks (type:task)
  2. Verify task rows have min-height 52px, paddingVertical 8px
  3. Verify the last task row has no bottom border and 8px bottom border radius

Grouped Search — Group Header (TransactionGroupListItem)

  1. Navigate to Search > Expenses > Group by: From
  2. Verify group header rows have min-height 52px, paddingVertical 4px
  3. Verify border-radius 0px on all group headers
  4. Verify 1px bottom border between group items (on the wrapper, not the pressable)
  5. Verify the last group has no bottom border (borderBottomWidth: 0)
  6. Verify the last group has 8px bottom-left and bottom-right border radius
  7. Select a group — verify the wrapper border color changes to theme.buttonHoveredBG

Grouped Search — Expanded Rows (TransactionGroupListExpanded)

  1. Expand a group by clicking the down arrow
  2. Verify expanded inner transaction rows have min-height 52px
  3. Verify expanded rows have paddingVertical from pv1Half (6px)
  4. Verify 1px bottom borders between all inner transaction rows (including on desktop)
  5. Verify the last expanded row has 8px bottom-left and bottom-right border radius
  6. Verify the expanded group's column header has no border (borderNone)
  7. Collapse and re-expand the group — verify the layout is consistent

Member Avatar (MemberListItemHeader)

  1. In Group by: From view, verify the member avatar in the group header is SMALL (28px)

Arrow Button (TransactionItemRow)

  1. On any row with a right arrow (›), verify the arrow button has paddingVertical 8px (pv2) with no extra horizontal padding
  2. Verify the arrow is vertically centered within the row

Mobile Regression Checks (resize browser to <1024px)

  1. Verify rows revert to card-style layout with mb2 gaps between them
  2. Verify row border-radius is still 8px (rounded card style)
  3. Verify avatar sizes remain DEFAULT (40px)
  4. Verify transactionGroupListItemStyle paddingVertical remains 6px
  5. Verify no compact table borders or 0-radius styles are applied
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…in-height, and bottom border separation

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@codecov
Copy link

codecov bot commented Mar 24, 2026

…ages

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…height and border separators

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323
Copy link
Contributor Author

@codex review

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…Radius and remove duplicate type

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323
Copy link
Contributor Author

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5343876a87

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines 1808 to +1809
case CONST.SEARCH.TABLE_COLUMNS.AVATAR:
columnWidth = {...getWidthStyle(variables.w40), ...styles.alignItemsCenter};
columnWidth = {...getWidthStyle(variables.w28), ...styles.alignItemsCenter};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Widen avatar column for default 40px icons

Changing TABLE_COLUMNS.AVATAR to 28px introduces overflow in desktop grouped views that still render 40px assets. CardListItemHeader uses ReportActionAvatars without a size prop (so it stays at default avatar size), and WithdrawalIDListItemHeader uses bank icons sized via iconSizeExtraLarge; both are wider than 28px. In Group by Card / Group by Withdrawal tables this causes icon overlap into neighboring columns and misaligned cell content. Keep this column at 40px or downsize those icon/avatar renderers to 28px in those views.

Useful? React with 👍 / 👎.

@github-actions
Copy link
Contributor

🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

@shawnborton
Copy link
Contributor

This is looking good!

For skeletons, can we make it so that the top of the skeletons doesn't have rounded edges and has a top border? We might also want to adjust the skeleton elements to more closely match the rows now (update button width, add space on the right where arrow goes so buttons line up, etc)

@shawnborton
Copy link
Contributor

On Reports > Reports, can you fix the logic so that the amount column uses the correct width? I had to do that in my POC here.

Similar, for Reports > Expenses, can you fix the logic so that the date column uses the correct width (smaller)? I also did that in my POC.

@shawnborton
Copy link
Contributor

For these types of grouped rows here:
CleanShot 2026-03-25 at 09 55 42@2x

Check that against my POC. I had to adjust the vertical padding of 6px down to 4px. Ideally you want those rows to also be 56px when they are not expanded.

@shawnborton
Copy link
Contributor

For the Expensify Card view, it would be nice to use a 28x28 avatar and also fix the date clumn width logic:
CleanShot 2026-03-25 at 09 57 46@2x

@shawnborton
Copy link
Contributor

Nested table rows have weird styles when selected - let's get rid of any border radius.
CleanShot 2026-03-25 at 09 58 35@2x

@shawnborton
Copy link
Contributor

Not sure if this has always been like this but I would love it if this spinner was vertically centered. If that exists on prod, feel free to ignore for now.
CleanShot 2026-03-25 at 09 59 55@2x

@shawnborton
Copy link
Contributor

shawnborton commented Mar 25, 2026

Same comment on these rows, let's get them down to 56px (change vertical padding of 6px to 4px).

CleanShot 2026-03-25 at 10 01 01@2x

@shawnborton
Copy link
Contributor

I think @dubielzyk-expensify had wanted a min height of 56px on all rows, not 52px:
CleanShot 2026-03-25 at 10 03 20@2x

1 similar comment
@shawnborton
Copy link
Contributor

I think @dubielzyk-expensify had wanted a min height of 56px on all rows, not 52px:
CleanShot 2026-03-25 at 10 03 20@2x

@shawnborton
Copy link
Contributor

I think that's all I have for now, great work on this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants