Add compact UI styles for search reports and expenses tables #86283
Add compact UI styles for search reports and expenses tables #86283Krishna2323 wants to merge 6 commits intoExpensify:mainfrom
Conversation
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…in-height, and bottom border separation Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
…ages Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…height and border separators Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@codex review |
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…Radius and remove duplicate type Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5343876a87
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| case CONST.SEARCH.TABLE_COLUMNS.AVATAR: | ||
| columnWidth = {...getWidthStyle(variables.w40), ...styles.alignItemsCenter}; | ||
| columnWidth = {...getWidthStyle(variables.w28), ...styles.alignItemsCenter}; |
There was a problem hiding this comment.
Widen avatar column for default 40px icons
Changing TABLE_COLUMNS.AVATAR to 28px introduces overflow in desktop grouped views that still render 40px assets. CardListItemHeader uses ReportActionAvatars without a size prop (so it stays at default avatar size), and WithdrawalIDListItemHeader uses bank icons sized via iconSizeExtraLarge; both are wider than 28px. In Group by Card / Group by Withdrawal tables this causes icon overlap into neighboring columns and misaligned cell content. Keep this column at 40px or downsize those icon/avatar renderers to 28px in those views.
Useful? React with 👍 / 👎.
|
🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
This is looking good! For skeletons, can we make it so that the top of the skeletons doesn't have rounded edges and has a top border? We might also want to adjust the skeleton elements to more closely match the rows now (update button width, add space on the right where arrow goes so buttons line up, etc) |
|
On Reports > Reports, can you fix the logic so that the amount column uses the correct width? I had to do that in my POC here. Similar, for Reports > Expenses, can you fix the logic so that the date column uses the correct width (smaller)? I also did that in my POC. |
|
I think @dubielzyk-expensify had wanted a min height of 56px on all rows, not 52px: |
1 similar comment
|
I think @dubielzyk-expensify had wanted a min height of 56px on all rows, not 52px: |
|
I think that's all I have for now, great work on this one! |






Explanation of Change
Fixed Issues
$ #86202
PROPOSAL:
Tests
Expenses Tab (TransactionListItem)
theme.bordercolortheme.buttonHoveredBGReports Tab (ExpenseReportListItem)
Tasks (TaskListItem)
type:task)Grouped Search — Group Header (TransactionGroupListItem)
theme.buttonHoveredBGGrouped Search — Expanded Rows (TransactionGroupListExpanded)
pv1Half(6px)borderNone)Member Avatar (MemberListItemHeader)
Arrow Button (TransactionItemRow)
pv2) with no extra horizontal paddingMobile Regression Checks (resize browser to <1024px)
mb2gaps between themtransactionGroupListItemStylepaddingVertical remains 6pxOffline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari