fix the database connection is closing issue. by Krishna2323 · Pull Request #748 · Expensify/react-native-onyx

Krishna2323 · 2026-03-07T23:44:52Z

Details

Related Issues

GH_LINK Expensify/App#84192

Automated Tests

Manual Tests

1. Basic persistence (no regression)

Open the app, log in, navigate around, interact with features that read/write data
Refresh the page — all data should persist
Check DevTools Console — no InvalidStateError or new errors should appear

2. Cross-tab recovery

Open the app in Tab A and Tab B
In Tab B's DevTools Console, run:

const req = indexedDB.open('OnyxDB', 9999);
req.onupgradeneeded = () => console.log('upgrade triggered');
req.onsuccess = () => { req.result.close(); console.log('done'); };

Go back to Tab A and continue using the app normally
Expected: Tab A continues working without crashing — the onversionchange handler closes the stale connection and the next operation opens a fresh one

Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

github-actions · 2026-03-07T23:45:09Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2026-03-07T23:46:53Z

I have read the CLA Document and I hereby sign the CLA

Krishna2323 · 2026-03-07T23:47:17Z

recheck

Krishna2323 · 2026-03-16T15:14:49Z

@codex review

chatgpt-codex-connector · 2026-03-16T15:38:24Z

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

We were unable to download your code in a timely manner.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

fabioh8010 · 2026-03-17T14:34:11Z

@Krishna2323 let me know once it's ready for review!

Krishna2323 · 2026-03-17T16:58:15Z

@fabioh8010 you can start reviewing the code. I'll add the app test recordings soon.

mountiny · 2026-03-18T14:17:11Z

@fabioh8010 can you please review when you get a time for it? thanks

fabioh8010 · 2026-03-18T19:57:15Z

Saving to review tomorrow morning 🫡

fabioh8010 · 2026-03-19T09:59:44Z

Reviewing

fabioh8010

initial review

lib/storage/providers/IDBKeyValProvider/createStore.ts

fabioh8010 · 2026-03-19T10:20:32Z

lib/storage/providers/IDBKeyValProvider/createStore.ts

+        // It seems like Safari sometimes likes to just close the connection.
+        // It's supposed to fire this event when that happens. Let's hope it does!
+        // eslint-disable-next-line no-param-reassign
+        db.onclose = () => {


Coul we improve the comment here to be more explanatory? An external link about it is also appreciated

Done. Please check.

fabioh8010 · 2026-03-19T10:23:58Z

lib/storage/providers/IDBKeyValProvider/createStore.ts

+
+    return (txMode, callback) =>
+        executeTransaction(txMode, callback).catch((error) => {
+            if (error instanceof DOMException && error.name === 'InvalidStateError') {


We should have a comment explaining why we need this check

Done. Please check.

tests/unit/storage/providers/createStoreTest.ts

fabioh8010 · 2026-03-24T08:50:11Z

@Krishna2323 What's the latest here?

Krishna2323 · 2026-03-24T08:56:16Z

Apologies for the delay 🙏🏻 — I missed this earlier. Reviewing the comments now.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

fabioh8010

minor comment

fabioh8010 · 2026-03-25T11:00:51Z

lib/storage/providers/IDBKeyValProvider/createStore.ts

+    // If the connection was closed between getDB() resolving and db.transaction() executing,
+    // the transaction throws InvalidStateError. We catch it and retry once with a fresh connection.
+    return (txMode, callback) =>
+        executeTransaction(txMode, callback).catch((error) => {
+            if (error instanceof DOMException && error.name === 'InvalidStateError') {


Suggested change

// If the connection was closed between getDB() resolving and db.transaction() executing,

// the transaction throws InvalidStateError. We catch it and retry once with a fresh connection.

return (txMode, callback) =>

executeTransaction(txMode, callback).catch((error) => {

if (error instanceof DOMException && error.name === 'InvalidStateError') {

return (txMode, callback) =>

executeTransaction(txMode, callback).catch((error) => {

// If the connection was closed between getDB() resolving and db.transaction() executing,

// the transaction throws InvalidStateError. We catch it and retry once with a fresh connection.

if (error.name === 'InvalidStateError') {

Are we sure it's always instance of DOMException? I would remove it.

Also I think it's best to leave comment closer to IF.

fabioh8010 · 2026-03-25T11:02:40Z

@tgolen mind reviewing since Vit is OOO? Thanks!

mkhutornyi · 2026-03-25T16:08:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Automated Tests

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

chatgpt-codex-connector · 2026-03-25T16:12:45Z

Codex Review: Didn't find any major issues. Keep it up!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

mkhutornyi · 2026-03-25T16:20:55Z

@Krishna2323 I followed 2. Cross-tab recovery on main but not able to reproduce crash. Is it consistently reproducible?

mkhutornyi

LGTM

fix the database connection is closing issue.

2946a6f

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot bot assigned Krishna2323 Mar 7, 2026

fix tests.

8aa7ec6

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

CLABotify added a commit to Expensify/CLA that referenced this pull request Mar 7, 2026

@Krishna2323 has signed the CLA in Expensify/react-native-onyx#748

6b59b24

Merge branch 'Expensify:main' into krishna2323/issue/84192

d5bb9b6

Krishna2323 marked this pull request as ready for review March 17, 2026 16:57

Krishna2323 requested a review from a team as a code owner March 17, 2026 16:57

melvin-bot bot requested review from cristipaval and removed request for a team March 17, 2026 16:57

Krishna2323 mentioned this pull request Mar 17, 2026

[$250] [Sentry] fix The database connection is closing issue Expensify/App#84192

Open

cristipaval requested review from mountiny and removed request for cristipaval March 18, 2026 11:13

mountiny requested a review from mkhutornyi March 18, 2026 14:19

fabioh8010 reviewed Mar 19, 2026

View reviewed changes

Merge branch 'Expensify:main' into krishna2323/issue/84192

e824ef7

address review comments.

f351319

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

fabioh8010 approved these changes Mar 25, 2026

View reviewed changes

mkhutornyi approved these changes Mar 25, 2026

View reviewed changes

Conversation

Krishna2323 commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Related Issues

Automated Tests

Manual Tests

Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Krishna2323 commented Mar 7, 2026

Uh oh!

Krishna2323 commented Mar 7, 2026

Uh oh!

Krishna2323 commented Mar 16, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 16, 2026

Uh oh!

fabioh8010 commented Mar 17, 2026

Uh oh!

Krishna2323 commented Mar 17, 2026

Uh oh!

mountiny commented Mar 18, 2026

Uh oh!

fabioh8010 commented Mar 18, 2026

Uh oh!

fabioh8010 commented Mar 19, 2026

Uh oh!

fabioh8010 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fabioh8010 Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

Krishna2323 Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

fabioh8010 Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

Krishna2323 Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fabioh8010 commented Mar 24, 2026

Uh oh!

Krishna2323 commented Mar 24, 2026

Uh oh!

fabioh8010 left a comment

Choose a reason for hiding this comment

Uh oh!

fabioh8010 Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

fabioh8010 commented Mar 25, 2026

Uh oh!

mkhutornyi commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Automated Tests

Screenshots/Videos

Uh oh!

chatgpt-codex-connector bot commented Mar 25, 2026

Uh oh!

mkhutornyi commented Mar 25, 2026

Uh oh!

mkhutornyi left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Krishna2323 commented Mar 7, 2026 •

edited

Loading

github-actions bot commented Mar 7, 2026 •

edited

Loading

mkhutornyi commented Mar 25, 2026 •

edited

Loading