Skip to content

Fix FairLogger crash when used with C++23#73

Merged
rbx merged 1 commit intoFairRootGroup:devfrom
fuhlig1:fix_c++23
Mar 17, 2026
Merged

Fix FairLogger crash when used with C++23#73
rbx merged 1 commit intoFairRootGroup:devfrom
fuhlig1:fix_c++23

Conversation

@fuhlig1
Copy link
Member

@fuhlig1 fuhlig1 commented Mar 16, 2026

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Mar 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 78017227-9d34-47ce-b3d8-3b205ea10ad2

📥 Commits

Reviewing files that changed from the base of the PR and between 2cb61c8 and 21fc727.

📒 Files selected for processing (1)
  • logger/Logger.h

📝 Walkthrough

Walkthrough

Static format strings in Logger::startColor and Logger::ColorOut are wrapped with fmt::runtime() in logger/Logger.h. The change adjusts format string construction without altering behavior or control flow.

Changes

Cohort / File(s) Summary
Format String Runtime Wrapping
logger/Logger.h
Updated fmt::format() calls to wrap format strings with fmt::runtime() in Logger::startColor and Logger::ColorOut implementations. Added a blank line after startColor.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to evaluate whether it relates to the changeset. Add a pull request description explaining the C++23 compatibility issue and why fmt::runtime is needed for the fix.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fix FairLogger crash when used with C++23' directly describes the main change: updating Logger formatting to use fmt::runtime for C++23 compatibility.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can suggest fixes for GitHub Check annotations.

Configure the reviews.tools.github-checks setting to adjust the time to wait for GitHub Checks to complete.

rbx
rbx previously approved these changes Mar 16, 2026
@rbx rbx changed the base branch from master to dev March 17, 2026 10:07
@rbx rbx dismissed their stale review March 17, 2026 10:07

The base branch was changed.

@rbx rbx merged commit 5aee797 into FairRootGroup:dev Mar 17, 2026
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants