Skip to content

feat: make DefaultSourceUrlResolver public#153

Merged
paodb merged 1 commit intomasterfrom
javier-godoy-patch-1
Apr 6, 2026
Merged

feat: make DefaultSourceUrlResolver public#153
paodb merged 1 commit intomasterfrom
javier-godoy-patch-1

Conversation

@javier-godoy
Copy link
Copy Markdown
Member

@javier-godoy javier-godoy commented Apr 6, 2026

Make DefaultSourceUrlResolver public, so that it can be extended in demo applications (see https://github.com/FlowingCode/AddonsDemo/issues/375)

Summary by CodeRabbit

  • Refactor
    • Improved API accessibility by making a core resolver class publicly available for external use.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 326483bc-6b93-476e-add5-7cd1811f1d28

📥 Commits

Reviewing files that changed from the base of the PR and between 2d58ced and a13fa6b.

📒 Files selected for processing (1)
  • src/main/java/com/flowingcode/vaadin/addons/demo/DefaultSourceUrlResolver.java

Walkthrough

The DefaultSourceUrlResolver class access modifier was changed from package-private to public. No logic, behavior, method signatures, or control flow were altered.

Changes

Cohort / File(s) Summary
Access Modifier Update
src/main/java/com/flowingcode/vaadin/addons/demo/DefaultSourceUrlResolver.java
Class declaration changed from package-private to public; implementation and method signatures remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: making the DefaultSourceUrlResolver class public.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch javier-godoy-patch-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 6, 2026

@javier-godoy javier-godoy requested review from paodb and scardanzan April 6, 2026 16:57
@javier-godoy javier-godoy marked this pull request as ready for review April 6, 2026 16:58
@paodb paodb merged commit 961bcbd into master Apr 6, 2026
3 checks passed
@paodb paodb deleted the javier-godoy-patch-1 branch April 6, 2026 17:28
@github-project-automation github-project-automation bot moved this from To Do to Pending release in Flowing Code Addons Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending release

Development

Successfully merging this pull request may close these issues.

2 participants