fix: process resource files AND fix: normalize leading slash in DemoSource path values#156
fix: process resource files AND fix: normalize leading slash in DemoSource path values#156
Conversation
WalkthroughUpdated Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@processor/src/main/java/com/flowingcode/vaadin/addons/demo/DemoSourceProcessor.java`:
- Around line 259-267: isFromMetaInfResources currently only checks
RESOURCE_ROOTS prefixes so a direct normalizedPath like
"/META-INF/resources/foo.js" is missed; update isFromMetaInfResources to first
normalize and test for a direct META-INF/resources prefix (e.g., check
normalizedPath.startsWith("META-INF/resources") ||
normalizedPath.startsWith("/META-INF/resources")) and return true for those
before iterating RESOURCE_ROOTS, preserving the existing logic that computes
relative = normalizedPath.substring(root.length()) and checks for
"META-INF/resources" there.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 91ae1666-8f63-400b-88de-bf29a5147c65
📒 Files selected for processing (1)
processor/src/main/java/com/flowingcode/vaadin/addons/demo/DemoSourceProcessor.java



Summary by CodeRabbit
Release Notes