Skip to content

fix: prevent horizontal orientation from collapsing to zero height#210

Open
ngonzalezpazFC wants to merge 1 commit intomasterfrom
fix-orientation-switch
Open

fix: prevent horizontal orientation from collapsing to zero height#210
ngonzalezpazFC wants to merge 1 commit intomasterfrom
fix-orientation-switch

Conversation

@ngonzalezpazFC
Copy link
Copy Markdown
Contributor

@ngonzalezpazFC ngonzalezpazFC commented Apr 17, 2026

Close #201

Summary by CodeRabbit

  • Bug Fixes
    • Corrected layout constraint in the grid container to improve component display.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a26677a7-e39e-4ab0-927f-dcc1e8b02f58

📥 Commits

Reviewing files that changed from the base of the PR and between b8c7763 and 8a4d250.

📒 Files selected for processing (1)
  • src/main/java/com/flowingcode/vaadin/addons/twincolgrid/TwinColGrid.java

Walkthrough

Modified the createHorizontalContainer method in TwinColGrid to adjust the inline style constraint applied to the HorizontalLayout from min-height: 0px to min-width: 0px. This single-line CSS property change targets horizontal orientation layout behavior without altering method logic or API contracts.

Changes

Cohort / File(s) Summary
CSS Constraint Update
src/main/java/com/flowingcode/vaadin/addons/twincolgrid/TwinColGrid.java
Modified inline style constraint in createHorizontalContainer from min-height: 0px to min-width: 0px to address horizontal orientation display issues.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • mlopezFC
  • paodb
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the fix: changing min-height constraint to min-width prevents horizontal orientation from collapsing to zero height, which is the exact problem reported in issue #201.
Linked Issues check ✅ Passed The code change directly addresses issue #201 by modifying the inline style constraint from min-height to min-width in the horizontal layout, which prevents the component from collapsing in horizontal orientations.
Out of Scope Changes check ✅ Passed The change is narrowly scoped to fixing the horizontal orientation issue; only one line was modified in the style constraint with no unrelated alterations to logic, control flow, or public APIs.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-orientation-switch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To Do

Development

Successfully merging this pull request may close these issues.

Horizontal orientation breaks

2 participants