Skip to content

chore(device-client): update publish config#546

Open
ancheetah wants to merge 1 commit intomainfrom
device-client-publish
Open

chore(device-client): update publish config#546
ancheetah wants to merge 1 commit intomainfrom
device-client-publish

Conversation

@ancheetah
Copy link
Collaborator

@ancheetah ancheetah commented Mar 16, 2026

JIRA Ticket

Description

update device client config for first time publishing

Summary by CodeRabbit

  • Chores
    • Updated device-client package configuration to publish as a public package, enabling users to access and install it.

@changeset-bot
Copy link

changeset-bot bot commented Mar 16, 2026

⚠️ No Changeset found

Latest commit: d706941

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link

coderabbitai bot commented Mar 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3e42b0e6-1109-454f-9412-d36bf605921d

📥 Commits

Reviewing files that changed from the base of the PR and between d119831 and d706941.

📒 Files selected for processing (1)
  • packages/device-client/package.json

📝 Walkthrough

Walkthrough

A publishConfig object is added to the device-client package.json file, setting the npm publishing access to public. This is a configuration-only change with no modifications to existing fields or removal of properties.

Changes

Cohort / File(s) Summary
Package Configuration
packages/device-client/package.json
Added publishConfig property with access: "public" to enable public npm publishing.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • ryanbas21

Poem

🐰 Hop hop, the package now takes flight,
Public access shining bright!
Device-client spreads its wings so wide,
To npm's world with grateful pride!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: updating the publish configuration for the device-client package.
Description check ✅ Passed The description includes a JIRA Ticket section and provides a brief description of the changes, though the description section is minimal.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch device-client-publish
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can scan for known vulnerabilities in your dependencies using OSV Scanner.

OSV Scanner will automatically detect and report security vulnerabilities in your project's dependencies. No additional configuration is required.

@nx-cloud
Copy link
Contributor

nx-cloud bot commented Mar 16, 2026

View your CI Pipeline Execution ↗ for commit d706941

Command Status Duration Result
nx run-many -t build --no-agents ✅ Succeeded 6s View ↗
nx affected -t build lint test typecheck e2e-ci ✅ Succeeded 51s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-16 17:35:38 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 16, 2026

Open in StackBlitz

@forgerock/davinci-client

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/davinci-client@546

@forgerock/device-client

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/device-client@546

@forgerock/journey-client

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/journey-client@546

@forgerock/oidc-client

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/oidc-client@546

@forgerock/protect

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/protect@546

@forgerock/sdk-types

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-types@546

@forgerock/sdk-utilities

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-utilities@546

@forgerock/iframe-manager

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/iframe-manager@546

@forgerock/sdk-logger

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-logger@546

@forgerock/sdk-oidc

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-oidc@546

@forgerock/sdk-request-middleware

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-request-middleware@546

@forgerock/storage

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/storage@546

commit: d706941

@github-actions
Copy link
Contributor

Deployed f507ca1 to https://ForgeRock.github.io/ping-javascript-sdk/pr-546/f507ca10c74bbed30f2cb88f28368385c393dd4e branch gh-pages in ForgeRock/ping-javascript-sdk

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.43%. Comparing base (4c17ba5) to head (d706941).
⚠️ Report is 27 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #546       +/-   ##
===========================================
+ Coverage   18.84%   79.43%   +60.59%     
===========================================
  Files         142       13      -129     
  Lines       27770      457    -27313     
  Branches      990      124      -866     
===========================================
- Hits         5232      363     -4869     
+ Misses      22538       94    -22444     

see 128 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

📦 Bundle Size Analysis

📦 Bundle Size Analysis

🆕 New Packages

🆕 @forgerock/journey-client - 87.3 KB (new)
🆕 @forgerock/journey-client - 0.0 KB (new)

➖ No Changes

@forgerock/sdk-logger - 1.6 KB
@forgerock/sdk-request-middleware - 4.5 KB
@forgerock/iframe-manager - 2.4 KB
@forgerock/sdk-oidc - 4.8 KB
@forgerock/storage - 1.5 KB
@forgerock/sdk-types - 7.9 KB
@forgerock/protect - 150.1 KB
@forgerock/device-client - 9.2 KB
@forgerock/davinci-client - 41.3 KB
@forgerock/sdk-utilities - 11.2 KB
@forgerock/oidc-client - 24.9 KB


13 packages analyzed • Baseline from latest main build

Legend

🆕 New package
🔺 Size increased
🔻 Size decreased
➖ No change

ℹ️ How bundle sizes are calculated
  • Current Size: Total gzipped size of all files in the package's dist directory
  • Baseline: Comparison against the latest build from the main branch
  • Files included: All build outputs except source maps and TypeScript build cache
  • Exclusions: .map, .tsbuildinfo, and .d.ts.map files

🔄 Updated automatically on each push to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants