Conversation
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdded a Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/journey-client/package.json`:
- Around line 39-40: Remove "vitest" and "vitest-canvas-mock" entries from the
dependencies section of package.json and ensure they remain declared under
devDependencies (they're already present there); update the lockfile by running
your package manager (npm/yarn/pnpm install) so downstream consumers don't
receive these test-only packages. Use the dependency names "vitest" and
"vitest-canvas-mock" to locate the entries to remove.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5b74c5d8-91f8-4f8a-9ed1-fc1b23a8aff8
📒 Files selected for processing (1)
packages/journey-client/package.json
packages/journey-client/package.json
Outdated
| "vitest": "catalog:vitest", | ||
| "vitest-canvas-mock": "catalog:vitest" |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Verify these packages are test-only (not imported by runtime source).
echo "Checking runtime source imports in packages/journey-client/src ..."
rg -nP --type=ts -C2 "['\"](vitest|vitest-canvas-mock)['\"]" packages/journey-client/src || true
echo
echo "Checking test wiring files ..."
rg -nP -C2 "vitest-canvas-mock|setupFiles|test:" \
packages/journey-client/vite.config.ts \
packages/journey-client/vitest.setup.tsRepository: ForgeRock/ping-javascript-sdk
Length of output: 13583
🏁 Script executed:
cat packages/journey-client/package.jsonRepository: ForgeRock/ping-javascript-sdk
Length of output: 2072
Move vitest and vitest-canvas-mock from runtime dependencies to devDependencies only.
These packages are test-only and should not be installed for downstream consumers. They are imported exclusively in test files (.test.ts) and test configuration (vitest.setup.ts), never in production source code. Remove them from dependencies; they are already correctly declared in devDependencies.
Proposed fix
"dependencies": {
"@forgerock/sdk-logger": "workspace:*",
"@forgerock/sdk-oidc": "workspace:*",
"@forgerock/sdk-request-middleware": "workspace:*",
"@forgerock/sdk-types": "workspace:*",
"@forgerock/sdk-utilities": "workspace:*",
"@forgerock/storage": "workspace:*",
"@reduxjs/toolkit": "catalog:",
- "tslib": "^2.3.0",
- "vitest": "catalog:vitest",
- "vitest-canvas-mock": "catalog:vitest"
+ "tslib": "^2.3.0"
},🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/journey-client/package.json` around lines 39 - 40, Remove "vitest"
and "vitest-canvas-mock" entries from the dependencies section of package.json
and ensure they remain declared under devDependencies (they're already present
there); update the lockfile by running your package manager (npm/yarn/pnpm
install) so downstream consumers don't receive these test-only packages. Use the
dependency names "vitest" and "vitest-canvas-mock" to locate the entries to
remove.
ryanbas21
force-pushed
the
fix-repository-packagejson
branch
2 times, most recently
from
617bdc2 to
c70a88c
Compare
|
View your CI Pipeline Execution ↗ for commit 5d6747a
☁️ Nx Cloud last updated this comment at |
@forgerock/davinci-client
@forgerock/device-client
@forgerock/journey-client
@forgerock/oidc-client
@forgerock/protect
@forgerock/sdk-types
@forgerock/sdk-utilities
@forgerock/iframe-manager
@forgerock/sdk-logger
@forgerock/sdk-oidc
@forgerock/sdk-request-middleware
@forgerock/storage
commit: |
|
Deployed 83f32a8 to https://ForgeRock.github.io/ping-javascript-sdk/pr-547/83f32a8a09e1b431d580f68687ad2a0c96276b0c branch gh-pages in ForgeRock/ping-javascript-sdk |
📦 Bundle Size Analysis📦 Bundle Size Analysis🆕 New Packages🆕 @forgerock/journey-client - 87.3 KB (new) ➖ No Changes➖ @forgerock/sdk-logger - 1.6 KB 13 packages analyzed • Baseline from latest Legend🆕 New package ℹ️ How bundle sizes are calculated
🔄 Updated automatically on each push to this PR |
ryanbas21
force-pushed
the
fix-repository-packagejson
branch
from
c70a88c to
a7dea24
Compare
There was a problem hiding this comment.
♻️ Duplicate comments (1)
packages/journey-client/package.json (1)
39-40:⚠️ Potential issue | 🟠 MajorRemove
viteandvitest-canvas-mockfrom runtime dependencies.Both packages are build/test tools that should only be in
devDependencies(where they're already declared). Adding them todependenciescauses downstream consumers to install unnecessary packages.
viteis a build tool used only invite.config.tsvitest-canvas-mockis imported only invitest.setup.tsfor test mocking,
Proposed fix
"dependencies": { "@forgerock/sdk-logger": "workspace:*", "@forgerock/sdk-oidc": "workspace:*", "@forgerock/sdk-request-middleware": "workspace:*", "@forgerock/sdk-types": "workspace:*", "@forgerock/sdk-utilities": "workspace:*", "@forgerock/storage": "workspace:*", "@reduxjs/toolkit": "catalog:", - "tslib": "^2.3.0", - "vite": "catalog:vite", - "vitest-canvas-mock": "catalog:vitest" + "tslib": "^2.3.0" },🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/journey-client/package.json` around lines 39 - 40, Remove the runtime dependency entries for "vite" and "vitest-canvas-mock" from the package.json dependencies block so they are not installed by downstream consumers; these tools are already declared in devDependencies and should remain only there—locate the dependencies object in package.json and delete the "vite": "catalog:vite" and "vitest-canvas-mock": "catalog:vitest" entries (do not modify the devDependencies entries).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@packages/journey-client/package.json`:
- Around line 39-40: Remove the runtime dependency entries for "vite" and
"vitest-canvas-mock" from the package.json dependencies block so they are not
installed by downstream consumers; these tools are already declared in
devDependencies and should remain only there—locate the dependencies object in
package.json and delete the "vite": "catalog:vite" and "vitest-canvas-mock":
"catalog:vitest" entries (do not modify the devDependencies entries).
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 0a5742df-afdf-44d6-93cf-5d847785ed0c
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
packages/journey-client/package.json
ryanbas21
force-pushed
the
fix-repository-packagejson
branch
from
a7dea24 to
5d6747a
Compare
2 participants
JIRA Ticket
n/a
Description
Fix the repository settings in package.json for provenance.
Summary by CodeRabbit