Skip to content

Feat/gid export#180

Merged
BotellaA merged 22 commits intonextfrom
feat/gid_export
Mar 18, 2026
Merged

Feat/gid export#180
BotellaA merged 22 commits intonextfrom
feat/gid_export

Conversation

@francoisbonneau
Copy link
Member

No description provided.

@github-actions github-actions bot changed the base branch from master to next March 16, 2026 17:14
@github-actions
Copy link

github-actions bot commented Mar 16, 2026

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 15 concern(s)
  • src/geode/io/model/svg_input.cpp:275:24: warning: [readability-function-size]

    function 'apply_command' exceeds recommended size/complexity thresholds

      275 |         geode::index_t apply_command( const std::vector< std::string >& tokens,
          |                        ^
    /__w/OpenGeode-IO/OpenGeode-IO/src/geode/io/model/svg_input.cpp:275:24: note: 5 parameters (threshold 4)
  • tests/model/test-msh.cpp:162:10: warning: [readability-function-cognitive-complexity]

    function 'test_brep_cube' has cognitive complexity of 28 (threshold 10)

      162 |     void test_brep_cube( const geode::BRep& brep )
          |          ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:170:9: note: +1, including nesting penalty of 0, nesting level increased to 1
      170 |         for( const auto& c : brep.corners() )
          |         ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:172:13: note: +2, including nesting penalty of 1, nesting level increased to 2
      172 |             OPENGEODE_EXCEPTION( brep.nb_boundaries( c.id() ) == 0,
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:5: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |     ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:172:13: note: +1
      172 |             OPENGEODE_EXCEPTION( brep.nb_boundaries( c.id() ) == 0,
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:9: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |         ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/absl/base/optimization.h:189:55: note: expanded from macro 'ABSL_PREDICT_FALSE'
      189 | #define ABSL_PREDICT_FALSE(x) (__builtin_expect(false || (x), false))
          |                                                       ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:174:13: note: +2, including nesting penalty of 1, nesting level increased to 2
      174 |             OPENGEODE_EXCEPTION( brep.nb_incidences( c.id() ) == 3,
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:5: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |     ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:174:13: note: +1
      174 |             OPENGEODE_EXCEPTION( brep.nb_incidences( c.id() ) == 3,
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:9: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |         ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/absl/base/optimization.h:189:55: note: expanded from macro 'ABSL_PREDICT_FALSE'
      189 | #define ABSL_PREDICT_FALSE(x) (__builtin_expect(false || (x), false))
          |                                                       ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:177:9: note: +1, including nesting penalty of 0, nesting level increased to 1
      177 |         for( const auto& l : brep.lines() )
          |         ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:179:13: note: +2, including nesting penalty of 1, nesting level increased to 2
      179 |             OPENGEODE_EXCEPTION( brep.nb_boundaries( l.id() ) == 2,
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:5: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |     ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:179:13: note: +1
      179 |             OPENGEODE_EXCEPTION( brep.nb_boundaries( l.id() ) == 2,
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:9: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |         ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/absl/base/optimization.h:189:55: note: expanded from macro 'ABSL_PREDICT_FALSE'
      189 | #define ABSL_PREDICT_FALSE(x) (__builtin_expect(false || (x), false))
          |                                                       ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:181:13: note: +2, including nesting penalty of 1, nesting level increased to 2
      181 |             OPENGEODE_EXCEPTION( brep.nb_incidences( l.id() ) == 2,
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:5: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |     ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:181:13: note: +1
      181 |             OPENGEODE_EXCEPTION( brep.nb_incidences( l.id() ) == 2,
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:9: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |         ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/absl/base/optimization.h:189:55: note: expanded from macro 'ABSL_PREDICT_FALSE'
      189 | #define ABSL_PREDICT_FALSE(x) (__builtin_expect(false || (x), false))
          |                                                       ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:184:9: note: +1, including nesting penalty of 0, nesting level increased to 1
      184 |         for( const auto& s : brep.surfaces() )
          |         ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:186:13: note: +2, including nesting penalty of 1, nesting level increased to 2
      186 |             OPENGEODE_EXCEPTION( brep.nb_boundaries( s.id() ) == 4,
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:5: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |     ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:186:13: note: +1
      186 |             OPENGEODE_EXCEPTION( brep.nb_boundaries( s.id() ) == 4,
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:9: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |         ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/absl/base/optimization.h:189:55: note: expanded from macro 'ABSL_PREDICT_FALSE'
      189 | #define ABSL_PREDICT_FALSE(x) (__builtin_expect(false || (x), false))
          |                                                       ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:188:13: note: +2, including nesting penalty of 1, nesting level increased to 2
      188 |             OPENGEODE_EXCEPTION( brep.nb_incidences( s.id() ) == 1,
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:5: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |     ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:188:13: note: +1
      188 |             OPENGEODE_EXCEPTION( brep.nb_incidences( s.id() ) == 1,
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:9: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |         ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/absl/base/optimization.h:189:55: note: expanded from macro 'ABSL_PREDICT_FALSE'
      189 | #define ABSL_PREDICT_FALSE(x) (__builtin_expect(false || (x), false))
          |                                                       ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:191:9: note: +1, including nesting penalty of 0, nesting level increased to 1
      191 |         for( const auto& b : brep.blocks() )
          |         ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:193:13: note: +2, including nesting penalty of 1, nesting level increased to 2
      193 |             OPENGEODE_EXCEPTION( brep.nb_boundaries( b.id() ) == 6,
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:5: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |     ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:193:13: note: +1
      193 |             OPENGEODE_EXCEPTION( brep.nb_boundaries( b.id() ) == 6,
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:9: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |         ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/absl/base/optimization.h:189:55: note: expanded from macro 'ABSL_PREDICT_FALSE'
      189 | #define ABSL_PREDICT_FALSE(x) (__builtin_expect(false || (x), false))
          |                                                       ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:195:13: note: +2, including nesting penalty of 1, nesting level increased to 2
      195 |             OPENGEODE_EXCEPTION( brep.nb_incidences( b.id() ) == 0,
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:5: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |     ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:195:13: note: +1
      195 |             OPENGEODE_EXCEPTION( brep.nb_incidences( b.id() ) == 0,
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:9: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |         ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/absl/base/optimization.h:189:55: note: expanded from macro 'ABSL_PREDICT_FALSE'
      189 | #define ABSL_PREDICT_FALSE(x) (__builtin_expect(false || (x), false))
          |                                                       ^
  • tests/model/test-msh.cpp:170:26: warning: [readability-identifier-length]

    variable name 'c' is too short, expected at least 3 characters

      170 |         for( const auto& c : brep.corners() )
          |                          ^
  • tests/model/test-msh.cpp:177:26: warning: [readability-identifier-length]

    variable name 'l' is too short, expected at least 3 characters

      177 |         for( const auto& l : brep.lines() )
          |                          ^
  • tests/model/test-msh.cpp:184:26: warning: [readability-identifier-length]

    variable name 's' is too short, expected at least 3 characters

      184 |         for( const auto& s : brep.surfaces() )
          |                          ^
  • tests/model/test-msh.cpp:191:26: warning: [readability-identifier-length]

    variable name 'b' is too short, expected at least 3 characters

      191 |         for( const auto& b : brep.blocks() )
          |                          ^
  • tests/model/test-msh.cpp:200:10: warning: [readability-function-cognitive-complexity]

    function 'test_brep_cone' has cognitive complexity of 29 (threshold 10)

      200 |     void test_brep_cone( const geode::BRep& brep )
          |          ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:208:9: note: +1, including nesting penalty of 0, nesting level increased to 1
      208 |         for( const auto& c : brep.corners() )
          |         ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:210:13: note: +2, including nesting penalty of 1, nesting level increased to 2
      210 |             OPENGEODE_EXCEPTION( brep.nb_boundaries( c.id() ) == 0,
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:5: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |     ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:210:13: note: +1
      210 |             OPENGEODE_EXCEPTION( brep.nb_boundaries( c.id() ) == 0,
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:9: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |         ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/absl/base/optimization.h:189:55: note: expanded from macro 'ABSL_PREDICT_FALSE'
      189 | #define ABSL_PREDICT_FALSE(x) (__builtin_expect(false || (x), false))
          |                                                       ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:212:13: note: +2, including nesting penalty of 1, nesting level increased to 2
      212 |             OPENGEODE_EXCEPTION( brep.nb_incidences( c.id() ) == 4
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:5: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |     ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:212:13: note: +1
      212 |             OPENGEODE_EXCEPTION( brep.nb_incidences( c.id() ) == 4
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:9: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |         ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/absl/base/optimization.h:189:55: note: expanded from macro 'ABSL_PREDICT_FALSE'
      189 | #define ABSL_PREDICT_FALSE(x) (__builtin_expect(false || (x), false))
          |                                                       ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:216:9: note: +1, including nesting penalty of 0, nesting level increased to 1
      216 |         for( const auto& l : brep.lines() )
          |         ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:218:13: note: +2, including nesting penalty of 1, nesting level increased to 2
      218 |             OPENGEODE_EXCEPTION( brep.nb_boundaries( l.id() ) == 2,
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:5: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |     ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:218:13: note: +1
      218 |             OPENGEODE_EXCEPTION( brep.nb_boundaries( l.id() ) == 2,
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:9: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |         ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/absl/base/optimization.h:189:55: note: expanded from macro 'ABSL_PREDICT_FALSE'
      189 | #define ABSL_PREDICT_FALSE(x) (__builtin_expect(false || (x), false))
          |                                                       ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:220:13: note: +2, including nesting penalty of 1, nesting level increased to 2
      220 |             OPENGEODE_EXCEPTION( brep.nb_incidences( l.id() ) > 1
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:5: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |     ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:220:13: note: +1
      220 |             OPENGEODE_EXCEPTION( brep.nb_incidences( l.id() ) > 1
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:9: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |         ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/absl/base/optimization.h:189:55: note: expanded from macro 'ABSL_PREDICT_FALSE'
      189 | #define ABSL_PREDICT_FALSE(x) (__builtin_expect(false || (x), false))
          |                                                       ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:221:38: note: +1
      221 |                                      && brep.nb_incidences( l.id() ) < 5,
          |                                      ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:224:9: note: +1, including nesting penalty of 0, nesting level increased to 1
      224 |         for( const auto& s : brep.surfaces() )
          |         ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:226:13: note: +2, including nesting penalty of 1, nesting level increased to 2
      226 |             OPENGEODE_EXCEPTION( brep.nb_boundaries( s.id() ) == 3,
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:5: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |     ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:226:13: note: +1
      226 |             OPENGEODE_EXCEPTION( brep.nb_boundaries( s.id() ) == 3,
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:9: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |         ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/absl/base/optimization.h:189:55: note: expanded from macro 'ABSL_PREDICT_FALSE'
      189 | #define ABSL_PREDICT_FALSE(x) (__builtin_expect(false || (x), false))
          |                                                       ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:228:13: note: +2, including nesting penalty of 1, nesting level increased to 2
      228 |             OPENGEODE_EXCEPTION( brep.nb_incidences( s.id() ) == 1
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:5: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |     ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:228:13: note: +1
      228 |             OPENGEODE_EXCEPTION( brep.nb_incidences( s.id() ) == 1
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:9: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |         ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/absl/base/optimization.h:189:55: note: expanded from macro 'ABSL_PREDICT_FALSE'
      189 | #define ABSL_PREDICT_FALSE(x) (__builtin_expect(false || (x), false))
          |                                                       ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:232:9: note: +1, including nesting penalty of 0, nesting level increased to 1
      232 |         for( const auto& b : brep.blocks() )
          |         ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:234:13: note: +2, including nesting penalty of 1, nesting level increased to 2
      234 |             OPENGEODE_EXCEPTION( brep.nb_boundaries( b.id() ) == 4,
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:5: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |     ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:234:13: note: +1
      234 |             OPENGEODE_EXCEPTION( brep.nb_boundaries( b.id() ) == 4,
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:9: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |         ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/absl/base/optimization.h:189:55: note: expanded from macro 'ABSL_PREDICT_FALSE'
      189 | #define ABSL_PREDICT_FALSE(x) (__builtin_expect(false || (x), false))
          |                                                       ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:236:13: note: +2, including nesting penalty of 1, nesting level increased to 2
      236 |             OPENGEODE_EXCEPTION( brep.nb_incidences( b.id() ) == 0,
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:5: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |     ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:236:13: note: +1
      236 |             OPENGEODE_EXCEPTION( brep.nb_incidences( b.id() ) == 0,
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:9: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |         ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/absl/base/optimization.h:189:55: note: expanded from macro 'ABSL_PREDICT_FALSE'
      189 | #define ABSL_PREDICT_FALSE(x) (__builtin_expect(false || (x), false))
          |                                                       ^
  • tests/model/test-msh.cpp:208:26: warning: [readability-identifier-length]

    variable name 'c' is too short, expected at least 3 characters

      208 |         for( const auto& c : brep.corners() )
          |                          ^
  • tests/model/test-msh.cpp:216:26: warning: [readability-identifier-length]

    variable name 'l' is too short, expected at least 3 characters

      216 |         for( const auto& l : brep.lines() )
          |                          ^
  • tests/model/test-msh.cpp:224:26: warning: [readability-identifier-length]

    variable name 's' is too short, expected at least 3 characters

      224 |         for( const auto& s : brep.surfaces() )
          |                          ^
  • tests/model/test-msh.cpp:232:26: warning: [readability-identifier-length]

    variable name 'b' is too short, expected at least 3 characters

      232 |         for( const auto& b : brep.blocks() )
          |                          ^
  • tests/model/test-msh.cpp:241:10: warning: [readability-function-cognitive-complexity]

    function 'test_brep_internal' has cognitive complexity of 24 (threshold 10)

      241 |     void test_brep_internal( const geode::BRep& brep )
          |          ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:249:9: note: +1, including nesting penalty of 0, nesting level increased to 1
      249 |         for( const auto& c : brep.corners() )
          |         ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:251:13: note: +2, including nesting penalty of 1, nesting level increased to 2
      251 |             OPENGEODE_EXCEPTION( brep.nb_boundaries( c.id() ) == 0,
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:5: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |     ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:251:13: note: +1
      251 |             OPENGEODE_EXCEPTION( brep.nb_boundaries( c.id() ) == 0,
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:9: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |         ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/absl/base/optimization.h:189:55: note: expanded from macro 'ABSL_PREDICT_FALSE'
      189 | #define ABSL_PREDICT_FALSE(x) (__builtin_expect(false || (x), false))
          |                                                       ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:253:13: note: +2, including nesting penalty of 1, nesting level increased to 2
      253 |             OPENGEODE_EXCEPTION( brep.nb_incidences( c.id() ) == 1
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:5: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |     ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:253:13: note: +1
      253 |             OPENGEODE_EXCEPTION( brep.nb_incidences( c.id() ) == 1
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:9: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |         ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/absl/base/optimization.h:189:55: note: expanded from macro 'ABSL_PREDICT_FALSE'
      189 | #define ABSL_PREDICT_FALSE(x) (__builtin_expect(false || (x), false))
          |                                                       ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:257:9: note: +1, including nesting penalty of 0, nesting level increased to 1
      257 |         for( const auto& l : brep.lines() )
          |         ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:259:13: note: +2, including nesting penalty of 1, nesting level increased to 2
      259 |             OPENGEODE_EXCEPTION( brep.nb_boundaries( l.id() ) == 2,
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:5: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |     ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:259:13: note: +1
      259 |             OPENGEODE_EXCEPTION( brep.nb_boundaries( l.id() ) == 2,
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:9: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |         ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/absl/base/optimization.h:189:55: note: expanded from macro 'ABSL_PREDICT_FALSE'
      189 | #define ABSL_PREDICT_FALSE(x) (__builtin_expect(false || (x), false))
          |                                                       ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:261:13: note: +2, including nesting penalty of 1, nesting level increased to 2
      261 |             OPENGEODE_EXCEPTION( brep.nb_incidences( l.id() ) == 1
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:5: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |     ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:261:13: note: +1
      261 |             OPENGEODE_EXCEPTION( brep.nb_incidences( l.id() ) == 1
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:9: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |         ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/absl/base/optimization.h:189:55: note: expanded from macro 'ABSL_PREDICT_FALSE'
      189 | #define ABSL_PREDICT_FALSE(x) (__builtin_expect(false || (x), false))
          |                                                       ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:267:9: note: +1, including nesting penalty of 0, nesting level increased to 1
      267 |         for( const auto& s : brep.surfaces() )
          |         ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:269:13: note: +2, including nesting penalty of 1, nesting level increased to 2
      269 |             OPENGEODE_EXCEPTION( brep.nb_boundaries( s.id() ) == 3,
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:5: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |     ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:269:13: note: +1
      269 |             OPENGEODE_EXCEPTION( brep.nb_boundaries( s.id() ) == 3,
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:9: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |         ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/absl/base/optimization.h:189:55: note: expanded from macro 'ABSL_PREDICT_FALSE'
      189 | #define ABSL_PREDICT_FALSE(x) (__builtin_expect(false || (x), false))
          |                                                       ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:271:13: note: +2, including nesting penalty of 1, nesting level increased to 2
      271 |             OPENGEODE_EXCEPTION( brep.nb_internal_lines( s ) == 1,
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:5: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |     ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:271:13: note: +1
      271 |             OPENGEODE_EXCEPTION( brep.nb_internal_lines( s ) == 1,
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:9: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |         ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/absl/base/optimization.h:189:55: note: expanded from macro 'ABSL_PREDICT_FALSE'
      189 | #define ABSL_PREDICT_FALSE(x) (__builtin_expect(false || (x), false))
          |                                                       ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:273:13: note: +2, including nesting penalty of 1, nesting level increased to 2
      273 |             OPENGEODE_EXCEPTION( brep.nb_incidences( s.id() ) == 0,
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:5: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |     ^
    /__w/OpenGeode-IO/OpenGeode-IO/tests/model/test-msh.cpp:273:13: note: +1
      273 |             OPENGEODE_EXCEPTION( brep.nb_incidences( s.id() ) == 0,
          |             ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/geode/basic/assert.hpp:121:9: note: expanded from macro 'OPENGEODE_EXCEPTION'
      121 |     if( ABSL_PREDICT_FALSE( !( condition ) ) )                                 \
          |         ^
    /__w/OpenGeode-IO/OpenGeode-IO/OpenGeode-16.3.0-rc.1-ubuntu/include/absl/base/optimization.h:189:55: note: expanded from macro 'ABSL_PREDICT_FALSE'
      189 | #define ABSL_PREDICT_FALSE(x) (__builtin_expect(false || (x), false))
          |                                                       ^
  • tests/model/test-msh.cpp:249:26: warning: [readability-identifier-length]

    variable name 'c' is too short, expected at least 3 characters

      249 |         for( const auto& c : brep.corners() )
          |                          ^
  • tests/model/test-msh.cpp:257:26: warning: [readability-identifier-length]

    variable name 'l' is too short, expected at least 3 characters

      257 |         for( const auto& l : brep.lines() )
          |                          ^
  • tests/model/test-msh.cpp:267:26: warning: [readability-identifier-length]

    variable name 's' is too short, expected at least 3 characters

      267 |         for( const auto& s : brep.surfaces() )
          |                          ^

Have any feedback or feature suggestions? Share it here.

@BotellaA BotellaA merged commit 62e17ed into next Mar 18, 2026
21 checks passed
@BotellaA BotellaA deleted the feat/gid_export branch March 18, 2026 16:53
@BotellaA
Copy link
Member

🎉 This PR is included in version 7.5.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants