fix: coerce env var values to strings for Kubernetes compatibility#150
Merged
vigneshrajsb merged 1 commit intomainfrom Mar 27, 2026
Merged
fix: coerce env var values to strings for Kubernetes compatibility#150vigneshrajsb merged 1 commit intomainfrom
vigneshrajsb merged 1 commit intomainfrom
Conversation
Kubernetes requires all env[].value fields to be strings. When env vars come from JSONB storage, numeric values like port numbers are preserved as numbers, causing kubectl apply to fail with: "cannot unmarshal number into Go struct field EnvVar.value of type string"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
env[].valuefields to be strings, but env vars sourced from JSONB storage can contain numeric values (e.g., port numbers stored as5432instead of"5432")kubectl applyto fail with:cannot unmarshal number into Go struct field EnvVar.value of type stringString()coercion in bothengines.ts(build container env) andutils.ts(deploy job env) where env var objects are constructedTest plan
buildkit.test.tsverifying numeric env values (e.g.,APP_PORT: 3000) are coerced to strings in the generated job YAMLutils.test.tsverifyingcreateJobcoerces numeric env values to strings