Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
|
/describe |
Owner
Author
|
/review |
Owner
Author
|
/improve |
Review Summary by QodoAdd search log tracking and UI improvements with terminology updates
WalkthroughsDescription• Add search log API with GET/POST routes to track popular searches • Create PopularSearchHistory component displaying top 10 searches • Replace "좋아요" (Like) terminology with "즐겨찾기" (Favorite) and Heart icon with Star • Refactor search history UI to chip layout with flex-wrap and add section titles • Update README formatting and changelog references Diagramflowchart LR
A["Search Input"] -->|POST| B["Search Log API"]
B -->|Store| C["search_logs Table"]
C -->|GET| D["Popular Search History"]
D -->|Display| E["PopularSearchHistory Component"]
F["Search History"] -->|Display| G["Chip Layout UI"]
H["Like Icon"] -->|Replace| I["Star Icon"]
File Changes1. apps/web/src/app/api/search/log/route.ts
|
Code Review by QodoNew Review StartedThis review has been superseded by a new analysisⓘ The new review experience is currently in Beta. Learn more |
1 similar comment
Code Review by QodoNew Review StartedThis review has been superseded by a new analysisⓘ The new review experience is currently in Beta. Learn more |
Code Review by Qodo
1. Empty results omit history UI
|
|
PR Description updated to latest commit (c01c0f0)
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
240
to
+255
| <p className="m-2">검색 결과가 없습니다.</p> | ||
| </div> | ||
| )} | ||
| {searchSongs.length === 0 && !query && ( | ||
|
|
||
| {/* {searchSongs.length === 0 && !query && ( | ||
| <div className="text-muted-foreground flex h-40 flex-col items-center justify-center"> | ||
| <Search className="h-8 w-8 opacity-50" /> | ||
| <p className="m-2">노래 제목이나 가수를 검색해보세요</p> | ||
| </div> | ||
| )} */} | ||
|
|
||
| {searchSongs.length === 0 && !query && ( | ||
| <div className="flex h-full flex-col justify-center gap-2"> | ||
| <SearchHistory onHistoryClick={handleHistoryClick} /> | ||
| <PopularSearchHistory onHistoryClick={handleHistoryClick} /> | ||
| </div> |
There was a problem hiding this comment.
1. Empty results omit history ui 📎 Requirement gap ≡ Correctness
In the empty-results state after a search (searchSongs.length === 0 && query), the page only shows the "검색 결과가 없습니다" message and does not render search history/popular searches. This does not meet the requirement to show search history and/or popular searches when search results are empty.
Agent Prompt
## Issue description
The HomePage currently renders `SearchHistory`/`PopularSearchHistory` only when `searchSongs.length === 0 && !query`, but the compliance requirement is to show these in the empty-results state (when a search is performed and yields no results).
## Issue Context
The current empty-results UI path is `!isPendingSearch && searchSongs.length === 0 && query`, which only renders the "검색 결과가 없습니다" message.
## Fix Focus Areas
- apps/web/src/app/search/HomePage.tsx[237-255]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Comment on lines
+20
to
+22
| <div className="flex flex-wrap gap-2 pb-4"> | ||
| {searchHistory.slice(10).map((term, index) => ( | ||
| <div |
There was a problem hiding this comment.
2. searchhistory.slice(10) hides chips 📎 Requirement gap ≡ Correctness
SearchHistory maps over searchHistory.slice(10), which skips the first 10 entries and often results in no chips being rendered for typical histories (<=10 items). This can prevent the chip-style search history UI from being displayed as required.
Agent Prompt
## Issue description
`SearchHistory` uses `searchHistory.slice(10)`, which skips the first 10 items. This often results in rendering no chip items, undermining the required chip-style search history UI.
## Issue Context
The component already has the required title and `flex-wrap` chip container, but the slicing logic likely should show the most recent items (e.g., first 10, or last 10).
## Fix Focus Areas
- apps/web/src/app/search/SearchHistory.tsx[20-22]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
📌 PR 제목
[Feat] : 검색 로그 기능 추가 및 UI 개선
📌 변경 사항
search_logs테이블 기반 검색 로그 API Route (GET/POST) 추가PopularSearchHistory) 추가💬 추가 참고 사항
PR Type
Enhancement, Tests
Description
Add search log API (GET/POST) with popular search tracking
Implement PopularSearchHistory component displaying top 10 searches
Replace "Like" terminology with "Favorites" (Heart → Star icon)
Refactor search history UI to chip-based flex-wrap layout
Update README formatting and terminology consistency
Diagram Walkthrough
File Walkthrough
9 files
New search log API endpoints GET and POSTReact Query hooks for search log operationsAPI client functions for search log requestsNew component displaying popular searches rankingRefactor to chip layout with title and iconIntegrate search log mutation on search executionReorganize layout to show history and popular searchesReplace Heart icon with Star for favorites buttonReplace Heart icon with Star and update labels6 files
Update comments from like to favorites terminologyUpdate comment terminology to favoritesUpdate page title to favorites managementUpdate tab label from like to favoritesUpdate changelog terminology to favoritesClean up formatting and update terminology1 files
Format code style improvements for readability1 files
Update sitemap timestamp3 files