为游戏崩溃界面导出和启动器日志导出添加加载指示器 by CiiLu · Pull Request #5694 · HMCL-dev/HMCL

CiiLu · 2026-03-02T04:36:39Z

前置：#5693

来自崩溃群

这两个地方涉及到文件压缩，如果待压缩文件比较大耗时会比较久，目前点击没有任何反馈用户可能以为没点到导致重复导出

Glavo · 2026-03-07T13:19:49Z

HMCL/src/main/java/org/jackhuang/hmcl/ui/main/SettingsPage.java

                LOG.warning("Failed to export logs", e);
-                Platform.runLater(() -> Controllers.dialog(i18n("settings.launcher.launcher_log.export.failed") + "\n" + StringUtils.getStackTrace(e), null, MessageType.ERROR));
+                Platform.runLater(() -> {
+                    spinnerPane.showSpinner();


为什么是 showSpinner？

Glavo · 2026-03-07T13:20:05Z

HMCL/src/main/java/org/jackhuang/hmcl/ui/main/SettingsPage.java


-            Platform.runLater(() -> Controllers.dialog(i18n("settings.launcher.launcher_log.export.success", outputFile)));
+            Platform.runLater(() -> {
+                spinnerPane.showSpinner();


为什么是 showSpinner？

Copilot

Pull request overview

This PR adds loading spinner indicators to two export operations in the HMCL launcher: the game crash info export in GameCrashWindow and the launcher log export in SettingsPage. Both operations involve file compression that can take significant time, and previously had no visual feedback, causing users to think the button click was not registered and leading to repeated exports.

Changes:

Wraps the export buttons in both GameCrashWindow and SettingsPage with SpinnerPane controls that show a loading spinner during the export operation.
Shows the spinner before starting the async export task and hides it in all completion paths (success and error).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
`HMCL/src/main/java/org/jackhuang/hmcl/ui/GameCrashWindow.java`	Adds a `SpinnerPane` wrapping the crash info export button, shows spinner on click, hides on completion. Adds `small-spinner-pane` CSS class.
`HMCL/src/main/java/org/jackhuang/hmcl/ui/main/SettingsPage.java`	Adds a `SpinnerPane` wrapping the log export button, shows spinner on click, hides on completion in both success and error paths.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-07T13:39:37Z

HMCL/src/main/java/org/jackhuang/hmcl/ui/main/SettingsPage.java

    @SuppressWarnings("FieldCanBeLocal")
    private final InvalidationListener updateListener;

+    private final SpinnerPane spinnerPane = new SpinnerPane();


The small-spinner-pane style class is missing on the spinnerPane in SettingsPage. Every other usage of SpinnerPane wrapping a button in the codebase adds spinnerPane.getStyleClass().add("small-spinner-pane") to reduce the spinner size (radius 10, stroke 3) to match the button. Without it, the default (larger) spinner will appear when loading, which will look out of place next to the small border button.

See examples: GameCrashWindow.java:119, AccountListItemSkin.java:95,130,165,170, CreateAccountPane.java:135, DialogPane.java:58, InputDialogPane.java:61, MicrosoftAccountLoginPane.java:108, AddAuthlibInjectorServerPane.java:79.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

HMCL/src/main/java/org/jackhuang/hmcl/ui/main/SettingsPage.java

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-21T14:47:44Z

HMCL/src/main/java/org/jackhuang/hmcl/ui/GameCrashWindow.java

+        return CompletableFuture.supplyAsync(() ->
                        logs.stream().map(Log::getLog).collect(Collectors.joining("\n")))
                .thenComposeAsync(logs -> {
                    long processStartTime = managedProcess.getProcess().info()


In exportGameCrashInfo(), the lambda parameter name logs in thenComposeAsync(logs -> { ... }) shadows the logs field. Renaming the parameter (e.g., logsText/logText) would make the code easier to follow and avoid accidental confusion between the list and the joined string.

Copilot · 2026-03-21T14:47:44Z

HMCL/src/main/java/org/jackhuang/hmcl/ui/main/SettingsPage.java

+                SpinnerPane exportLogPane = new SpinnerPane();
+
                JFXButton logButton = FXUtils.newBorderButton(i18n("settings.launcher.launcher_log.export"));
-                logButton.setOnAction(e -> onExportLogs());
+                exportLogPane.setContent(logButton);
+                logButton.setOnAction(e -> {


SpinnerPane wrapping a button should include the small-spinner-pane style class; otherwise the spinner tends to be oversized and can shift the layout compared to other spinner-wrapped buttons in the UI (e.g., LogWindow export dump). Add the style class to exportLogPane for consistent sizing.

Copilot · 2026-03-21T14:47:45Z

HMCL/src/main/java/org/jackhuang/hmcl/ui/main/SettingsPage.java

+    private CompletableFuture<Path> onExportLogs() {
+        return CompletableFuture.supplyAsync(Lang.wrap(() -> {
            String nameBase = "hmcl-exported-logs-" + LocalDateTime.now().format(DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH-mm-ss"));


onExportLogs() performs file I/O and compression but uses CompletableFuture.supplyAsync(...) with the default executor (ForkJoin common pool). Use Schedulers.io() (and pass it as the executor argument to supplyAsync) so this work runs on the project’s I/O pool/virtual threads instead of competing with compute tasks.

Copilot · 2026-03-21T14:47:45Z

HMCL/src/main/java/org/jackhuang/hmcl/ui/GameCrashWindow.java

+    private CompletableFuture<Path> exportGameCrashInfo() {
        Path logFile = Paths.get("minecraft-exported-crash-info-" + LocalDateTime.now().format(DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH-mm-ss")) + ".zip").toAbsolutePath();

-        CompletableFuture.supplyAsync(() ->
+        return CompletableFuture.supplyAsync(() ->
                        logs.stream().map(Log::getLog).collect(Collectors.joining("\n")))
                .thenComposeAsync(logs -> {
                    long processStartTime = managedProcess.getProcess().info()


exportGameCrashInfo() ultimately does log export/compression work, but the initial CompletableFuture.supplyAsync(...) uses the default executor (common pool). Consider switching to Schedulers.io() for these async stages to keep I/O work off the compute pool and take advantage of the project’s I/O executor/virtual threads.

update

f71b2ac

CiiLu changed the title ~~update~~ 为游戏崩溃界面导出和启动器日志导出添加加载指示器 Mar 2, 2026

Glavo reviewed Mar 7, 2026

View reviewed changes

CiiLu and others added 2 commits March 7, 2026 21:22

update

eb4fc9b

Merge remote-tracking branch 'upstream/main' into ed

c8e2189

Glavo requested a review from Copilot March 7, 2026 13:36

Copilot started reviewing on behalf of Glavo March 7, 2026 13:36 View session

Copilot AI reviewed Mar 7, 2026

View reviewed changes

Glavo added 3 commits March 21, 2026 22:03

Merge remote-tracking branch 'upstream/main' into ed

5a6f439

优化游戏崩溃窗口导出功能的加载状态

20863b8

优化日志导出功能的异步处理和加载状态

f15f394

Glavo requested a review from Copilot March 21, 2026 14:35

Copilot started reviewing on behalf of Glavo March 21, 2026 14:36 View session

Copilot AI reviewed Mar 21, 2026

View reviewed changes

HMCL/src/main/java/org/jackhuang/hmcl/ui/main/SettingsPage.java Show resolved Hide resolved

HMCL/src/main/java/org/jackhuang/hmcl/ui/main/SettingsPage.java Show resolved Hide resolved

优化设置页面异步任务调度

9f0cab5

Glavo requested a review from Copilot March 21, 2026 14:44

Copilot started reviewing on behalf of Glavo March 21, 2026 14:44 View session

Copilot AI reviewed Mar 21, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

为游戏崩溃界面导出和启动器日志导出添加加载指示器#5694

为游戏崩溃界面导出和启动器日志导出添加加载指示器#5694
CiiLu wants to merge 7 commits intoHMCL-dev:mainfrom
CiiLu:ed

CiiLu commented Mar 2, 2026

Uh oh!

Glavo Mar 7, 2026

Uh oh!

Glavo Mar 7, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 7, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 21, 2026

Uh oh!

Copilot AI Mar 21, 2026

Uh oh!

Copilot AI Mar 21, 2026

Uh oh!

Copilot AI Mar 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

CiiLu commented Mar 2, 2026

前置：#5693

Uh oh!

Glavo Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Glavo Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants