LegacyForms: Fix TypeError for attachments exceeding upload limit#11335
Open
LeTammo wants to merge 1 commit intoILIAS-eLearning:release_10from
Open
LegacyForms: Fix TypeError for attachments exceeding upload limit#11335LeTammo wants to merge 1 commit intoILIAS-eLearning:release_10from
LeTammo wants to merge 1 commit intoILIAS-eLearning:release_10from
Conversation
…ding upload limit
mjansenDatabay
added
bugfix
php
LeTammo
changed the title
LeTammo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR resolves an issue described in this mantis report.
This fix prevents the TypeError from occurring when uploading attachments that exceed the file size limit if an
ilTextAreaInputGUIelement is contained in the same legacy property form.It is fixed by adding safeguard checks to ensure that in ilTextAreaInputGUI the getInput() function only attempts to purify the PostVar if it is not null.