ULTRA l1b priority 1,2,3,4#2917
Open
lacoak21 wants to merge 5 commits intoIMAP-Science-Operations-Center:devfrom
Open
ULTRA l1b priority 1,2,3,4#2917lacoak21 wants to merge 5 commits intoIMAP-Science-Operations-Center:devfrom
lacoak21 wants to merge 5 commits intoIMAP-Science-Operations-Center:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for generating ULTRA L1B “priority” direct-event (DE) products (priority 1–4) alongside existing DE processing, and updates CDF metadata accordingly so these products can be written with correct global attributes.
Changes:
- Add global CDF attributes for ULTRA L1B priority 1–4 DE logical sources.
- Update ULTRA L1B processing to detect and convert priority DE L1A inputs into corresponding L1B outputs.
- Add a unit test to validate creating an L1B priority DE dataset from an L1A priority input.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
imap_processing/ultra/l1b/ultra_l1b.py |
Extends DE product detection/conversion logic to include priority DE products. |
imap_processing/cdf/config/imap_ultra_global_cdf_attrs.yaml |
Defines global attrs for new L1B priority DE logical sources (45/90 sensors, priorities 1–4). |
imap_processing/tests/ultra/unit/test_ultra_l1b.py |
Adds a unit test to ensure a priority L1A DE can be converted to the correct priority L1B DE logical source. |
imap_processing/ultra/l1c/ultra_l1c.py |
Adds a TODO note about selecting which L1B priority DE product should feed L1C generation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Closes #2912
Overview
Produce Priority 1,2,3, and 4 DE products. Eventually one of them will be used(varies by pointing) to produce the psets.
File changes
Testing
Test for priority product