Fix bug in pvec pop resulting in empty tail#64
Open
georgematheos wants to merge 5 commits intoJuliaCollections:masterfrom
Open
Fix bug in pvec pop resulting in empty tail#64georgematheos wants to merge 5 commits intoJuliaCollections:masterfrom
pop resulting in empty tail#64georgematheos wants to merge 5 commits intoJuliaCollections:masterfrom
Conversation
When calling `pop` on a persistent vector with, eg., 33 elements, we have a `tail` of length 1. After this `pop` call, there was a bug where the resulting pvec had a tail of length `0` rather than a tail of length `32`. This causes errors, for instance when calling `iterate`, which expects a nonempty tail. This PR fixes the behavior by adding a branch in `pop` function for when the tail length is currently `1` (in which case we make the new tail be `pop(trie)`).
Update PersistentVectorTest.jl
Contributor
Author
|
(just added a test for this behavior) |
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
==========================================
+ Coverage 77.30% 78.38% +1.07%
==========================================
Files 7 7
Lines 379 384 +5
==========================================
+ Hits 293 301 +8
+ Misses 86 83 -3
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling
popon a persistent vector with, eg., 33 elements, we have atailof length 1. After thispopcall, there was a bug where the resulting pvec had a tail of length0rather than a tail of length32. This causes errors, for instance when callingiterate, which expects a nonempty tail. This PR fixes the behavior by adding a branch inpopfunction for when the tail length is currently1(in which case we make the new tail bepop(trie)).