Skip to content

Fix credential-provision rotation settings, validation, and delivery handling#1956

Merged
sk-keeper merged 1 commit intoreleasefrom
credential-provision-fixes
Apr 14, 2026
Merged

Fix credential-provision rotation settings, validation, and delivery handling#1956
sk-keeper merged 1 commit intoreleasefrom
credential-provision-fixes

Conversation

@tbjones-ks
Copy link
Copy Markdown
Contributor

Summary

Fixes and improvements for the credential-provision command based on customer feedback and testing.

Bug Fixes

  • Fix rotation settings linking to PAM Configuration instead of PAM Directory when directory_uid is provided
  • Fix group assignment success reporting — only show success for groups that actually succeeded
  • Send DN instead of username for add-to-group operations
  • Remove stale delivery.method references

New Validation

  • Validate directory_uid points to a pamDirectory record type
  • Validate ad_groups requires directory_uid
  • Validate distinguished_name {username} placeholder has a username source
  • Warn when delivery.share_to user may not exist in Keeper
  • Deprecation check for pam.rotation YAML structure with migration guide
  • Deprecation warning for pam_config_uid in YAML — recommend -c flag

Improvements

  • Add support for folder UIDs in vault.folder (in addition to folder paths)
  • Skip email delivery gracefully when email.config_name is set to none/null
  • Add Gateway version check — skip AD operations if Gateway < 1.8.0
  • Continue with PAM User creation when AD user already exists instead of failing

Test plan

  • Rotation links to PAM Directory when directory_uid provided
  • Folder UID accepted in vault.folder
  • Email config_name=none skips email with warning
  • Gateway version < 1.8.0 skips AD with warning
  • AD user already exists continues flow
  • Group failures reported accurately
  • pam.rotation deprecation message shows
  • pam_config_uid deprecation warning shows
  • directory_uid wrong record type caught
  • ad_groups without directory_uid caught

Change List:
   - Fix rotation settings linking to PAM Configuration instead of PAM Directory when directory_uid is provided
   - Add support for folder UIDs in vault.folder (in addition to folder paths)
   - Skip email delivery gracefully when email.config_name is set to none/null
   - Add Gateway version check — skip AD operations if Gateway < 1.8.0
   - Continue with PAM User creation when AD user already exists instead of failing
   - Fix group assignment success reporting — only show success for groups that actually succeeded
   - Send DN instead of username for add-to-group operations
   - Add deprecation check for pam.rotation YAML structure with migration guide
   - Add deprecation warning for pam_config_uid in YAML — recommend -c flag
   - Validate directory_uid points to a pamDirectory record type
   - Validate ad_groups requires directory_uid
   - Validate distinguished_name {username} placeholder has a username source
   - Warn when delivery.share_to user may not exist in Keeper
   - Remove stale delivery.method references
   - Fix stale resource_uid comment references to directory_uid
@tbjones-ks tbjones-ks requested review from maksimu and sk-keeper April 14, 2026 05:33
@sk-keeper sk-keeper merged commit 8ef1621 into release Apr 14, 2026
4 checks passed
@sk-keeper sk-keeper deleted the credential-provision-fixes branch April 14, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants