Fix credential-provision rotation settings, validation, and delivery handling#1956
Merged
Fix credential-provision rotation settings, validation, and delivery handling#1956
Conversation
Change List:
- Fix rotation settings linking to PAM Configuration instead of PAM Directory when directory_uid is provided
- Add support for folder UIDs in vault.folder (in addition to folder paths)
- Skip email delivery gracefully when email.config_name is set to none/null
- Add Gateway version check — skip AD operations if Gateway < 1.8.0
- Continue with PAM User creation when AD user already exists instead of failing
- Fix group assignment success reporting — only show success for groups that actually succeeded
- Send DN instead of username for add-to-group operations
- Add deprecation check for pam.rotation YAML structure with migration guide
- Add deprecation warning for pam_config_uid in YAML — recommend -c flag
- Validate directory_uid points to a pamDirectory record type
- Validate ad_groups requires directory_uid
- Validate distinguished_name {username} placeholder has a username source
- Warn when delivery.share_to user may not exist in Keeper
- Remove stale delivery.method references
- Fix stale resource_uid comment references to directory_uid
sk-keeper
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes and improvements for the
credential-provisioncommand based on customer feedback and testing.Bug Fixes
directory_uidis provideddelivery.methodreferencesNew Validation
directory_uidpoints to apamDirectoryrecord typead_groupsrequiresdirectory_uiddistinguished_name{username}placeholder has a username sourcedelivery.share_touser may not exist in Keeperpam.rotationYAML structure with migration guidepam_config_uidin YAML — recommend-cflagImprovements
vault.folder(in addition to folder paths)email.config_nameis set tonone/nullTest plan