Added --purge flag to rm command to differentiate remove vs. delete#1965
Open
sshrushanth-ks wants to merge 2 commits intodelete-shared-record-modfrom
Open
Added --purge flag to rm command to differentiate remove vs. delete#1965sshrushanth-ks wants to merge 2 commits intodelete-shared-record-modfrom
sshrushanth-ks wants to merge 2 commits intodelete-shared-record-modfrom
Conversation
The rm command now supports two distinct operations: - Default (no flag): removes the record from the current user's vault only, leaving it intact for other users (pre_delete/unlink flow). - --purge: permanently hard-deletes the record for all users via record_update/delete_records. Requires the caller to be the record owner; non-owned records are skipped with a warning. Also fixed rm failing to resolve records in shared folders when searched by title, by adding a global fallback search across all vault folders. Improved the not-found error message to be more actionable.
- Added sync_down after a successful purge so the local cache reflects deletions immediately rather than waiting for a lazy sync - vault_changed and BreachWatch cleanup are now only triggered when at least one record was actually deleted successfully - Added a success log showing how many records were permanently deleted - Global title fallback now errors with a list of matching UIDs when more than one record shares the same title, preventing unintended bulk deletes on ambiguous names
sshrushanth-ks
requested review from
pvagare-ks
and removed request for
adeshmukh-ks
amangalampalli-ks
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rm command now supports two distinct operations: