Skip to content

fix(cmake): Remove SOVERSION and VERSION from vtk_module_build_modules #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexyPellegrini merged 1 commit into from
Mar 12, 2026
Merged

fix(cmake): Remove SOVERSION and VERSION from vtk_module_build_modules #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions vtk_sdk_python_wheel_helper/VTKSDKInstallRuntimeDeps.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@
`POST_EXCLUDE_REGEXES`, `POST_INCLUDE_FILES` and `POST_EXCLUDE_FILES`
are forwarded to underlying `file(GET_RUNTIME_DEPENDENCIES)`

Wheels are packaged as ZIP archives. This is important as ZIPs do not support symlinks.
If one of your target links against a symlink, the symlink will be replaced by a COPY of the so/dylib.
This may significantly increase the size of your packages.

.. code-block:: cmake

vtksdk_build_modules(<package_name>
Expand Down
4 changes: 1 addition & 3 deletions vtk_sdk_python_wheel_helper/VTKSDKModuleBuilder.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
vtksdk_build_modules(<package_name>
[SOURCE_DIR <path>]
[ENABLE_TESTS <TRUE_VALUE|FALSE_VALUE>]
[STATIC]
[LAYOUT <Runtime|SDK>]
[STATIC]
[DEPENDENCIES <packages...>]
MODULES <module>...
)
Expand Down Expand Up @@ -131,8 +131,6 @@ function(vtksdk_build_modules package_name)
RUNTIME_DESTINATION "${lib_install_dir}"
LIBRARY_DESTINATION "${lib_install_dir}"
UTILITY_TARGET vtk_sdk_utility_target
VERSION ${SKBUILD_PROJECT_VERSION}
SOVERSION "1"
${sdk_args_build}
)

Expand Down
Loading